Repository navigation
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex (GPT-6). Scope: source/workflow changes and local validation. Independent review is pending.
What changed
Pin QPK using existing pyproject/qsl/lock files. Route regular, runtime-error and paper-
observation sends through shared intent transport; preserve the original prefix, 10-second timeout
and no-redirect observation behavior. Install entrypoint redaction and add report serialization
coverage. Update integration expectations for the pinned SDK: observation does not authorize
broker writes, and strategy labels are localized.
How verified
Full suite: 2625 passed, 3 skipped, 322 subtests; one macOS system-Bash scanner fixture failed.
All 14 scanner cases and 39 subtests then passed using a temporary GNU Bash, with assertions
unchanged. Notification, receipt and no-symlink report scans pass using a real temporary
directory. Ruff, lock, documentation and diff checks passed. No live account or Telegram/cloud
call occurred.
Why
Credential-bearing notification parameters and runtime output must not enter public run reports or
Git data branches.
Risk
High: SDK pin and notifications. The QPK command-gate assertion is stricter (broker_write_allowed
remains false), not relaxed. No production trade, risk, routing or gate code changed. Existing in-
memory credentials retain QPK compatibility transport without process-environment mutation. No
deploy, merge, labels or cloud configuration changes.