Skip to content

fix: centralize Telegram sends with credential-free intents - #692

Draft
Pigbibi wants to merge 1 commit into
mainfrom
fix/notification-intent-safety
Draft

Pigbibi wants to merge 1 commit into
mainfrom
fix/notification-intent-safety

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator

AI assistance

Codex (GPT-6). Scope: source/workflow changes and local validation. Independent review is pending.

What changed

Pin QPK using existing pyproject/qsl/lock files. Route regular, runtime-error and paper-
observation sends through shared intent transport; preserve the original prefix, 10-second timeout
and no-redirect observation behavior. Install entrypoint redaction and add report serialization
coverage. Update integration expectations for the pinned SDK: observation does not authorize
broker writes, and strategy labels are localized.

How verified

Full suite: 2625 passed, 3 skipped, 322 subtests; one macOS system-Bash scanner fixture failed.
All 14 scanner cases and 39 subtests then passed using a temporary GNU Bash, with assertions
unchanged. Notification, receipt and no-symlink report scans pass using a real temporary
directory. Ruff, lock, documentation and diff checks passed. No live account or Telegram/cloud
call occurred.

Why

Credential-bearing notification parameters and runtime output must not enter public run reports or
Git data branches.

Risk

High: SDK pin and notifications. The QPK command-gate assertion is stricter (broker_write_allowed
remains false), not relaxed. No production trade, risk, routing or gate code changed. Existing in-
memory credentials retain QPK compatibility transport without process-environment mutation. No
deploy, merge, labels or cloud configuration changes.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant