Repository navigation
fix: propagate HK strategy retirement policy - #684
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Pigbibi
commented
Nov 1, 2026
Pigbibi
left a comment
Collaborator
Author
There was a problem hiding this comment.
Self-review of the current PR head after synchronizing main and passing CI: no blocking findings.
- Dependency and lock changes update only HkEquityStrategies; US strategy and QPK pins remain unchanged.
- Retired canonical profiles and aliases are excluded from selection, loading, configuration, status output and dry-run switch plans. Historical metadata and adapters remain available.
- Disabled HK notification inspection reads the historical HK definition and checks platform compatibility. It still requires canonical identity, disabled target, paper mode, both dry-run flags, unchanged source/configuration, and the existing paused scheduler controls. New tests reject US/research-only profiles and unsafe enabled/live/non-dry-run combinations. No canary was invoked.
- Latest Python 3.12 CI passed 2,559 tests and 283 subtests (1 skip), plus lint, lock/pin checks, 9 lifecycle and 92 image-only workflow cases. Documentation, dependency-impact and secret-scanning checks passed.
- The final PR diff contains only the intended eight files. No deployment, IAM, secret, runtime-target configuration or live-trading operation. Local pytest/shell tests were stopped after native module loading stalled. This is an implementation self-review, not an independent reviewer approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex (GPT-6). Implementation and self-review by the same assistant.
What changed
Pin HkEquityStrategies to the current retirement policy. HK Global ETF and HK low-vol dividend are no longer selectable through the registry, loader, runtime configuration, or dry-run switch planner. Keep historical catalog metadata and adapter lookup available; leave US strategy and QPK pins unchanged.
Preserve inspection of existing disabled HK notification targets through the historical HK catalog. Keep disabled, paper, dry-run, canonical-profile, platform and source/configuration checks; reject US/research-only profiles. Add regressions for these boundaries.
Update regression tests and English/Chinese usage documentation. This change does not deploy or change runtime targets, IAM, secrets, or live trading settings.
How verified
uv.lock; only the intended shared dependency revisions changed.