Skip to content

fix: propagate HK strategy retirement policy - #684

Merged
Pigbibi merged 3 commits into
mainfrom
fix/propagate-hk-cn-retirement-policy
Nov 1, 2026
Merged

Pigbibi merged 3 commits into
mainfrom
fix/propagate-hk-cn-retirement-policy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

AI assistance

OpenAI Codex (GPT-6). Implementation and self-review by the same assistant.

What changed

Pin HkEquityStrategies to the current retirement policy. HK Global ETF and HK low-vol dividend are no longer selectable through the registry, loader, runtime configuration, or dry-run switch planner. Keep historical catalog metadata and adapter lookup available; leave US strategy and QPK pins unchanged.

Preserve inspection of existing disabled HK notification targets through the historical HK catalog. Keep disabled, paper, dry-run, canonical-profile, platform and source/configuration checks; reject US/research-only profiles. Add regressions for these boundaries.

Update regression tests and English/Chinese usage documentation. This change does not deploy or change runtime targets, IAM, secrets, or live trading settings.

How verified

  • Inspected the old and new upstream allowlists and dependency source changes.
  • Regenerated uv.lock; only the intended shared dependency revisions changed.
  • Python 3.12 CI: 2,559 tests and 283 subtests passed, with 1 skip. Lint, lock/pin checks, 9 lifecycle condition cases, 92 image-only shell cases, documentation, commit convention, shared dependency impact and Gitleaks checks passed. CI run.
  • Local lint and documentation checks passed. Local pytest and the local shell suite stalled during native module loading on macOS and were stopped; test acceptance is based on successful Linux CI.
  • Retirement regressions cover canonical selection, aliases, direct loaders, and retained historical metadata/adapters. Existing selection expectations now require rejection.
  • Deployment workflow triggers were inspected: this PR and merge do not dispatch deployment.

Pigbibi and others added 3 commits November 1, 2026 15:59
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5d56f188-b5de-4e2d-ac68-dabf6b84ae13
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi Pigbibi left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review of the current PR head after synchronizing main and passing CI: no blocking findings.

  • Dependency and lock changes update only HkEquityStrategies; US strategy and QPK pins remain unchanged.
  • Retired canonical profiles and aliases are excluded from selection, loading, configuration, status output and dry-run switch plans. Historical metadata and adapters remain available.
  • Disabled HK notification inspection reads the historical HK definition and checks platform compatibility. It still requires canonical identity, disabled target, paper mode, both dry-run flags, unchanged source/configuration, and the existing paused scheduler controls. New tests reject US/research-only profiles and unsafe enabled/live/non-dry-run combinations. No canary was invoked.
  • Latest Python 3.12 CI passed 2,559 tests and 283 subtests (1 skip), plus lint, lock/pin checks, 9 lifecycle and 92 image-only workflow cases. Documentation, dependency-impact and secret-scanning checks passed.
  • The final PR diff contains only the intended eight files. No deployment, IAM, secret, runtime-target configuration or live-trading operation. Local pytest/shell tests were stopped after native module loading stalled. This is an implementation self-review, not an independent reviewer approval.

@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 1, 2026
@Pigbibi
Pigbibi merged commit ca88013 into main Nov 1, 2026
11 checks passed
@Pigbibi
Pigbibi deleted the fix/propagate-hk-cn-retirement-policy branch November 1, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant