Skip to content

fix: Preserve source evidence in attention notifications - #980

Merged
Pigbibi merged 2 commits into
mainfrom
fix/preserve-attention-source-evidence
Nov 6, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/preserve-attention-source-evidence

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

AI assistance

Implemented with OpenAI Codex (GPT-6). Request independent review from the configured Codex integration on this exact head.

What changed

Retain allowlisted execution block causes in incident attention messages instead of replacing them with the broad incident kind. Pass existing started_at and console_run_url fields to both supported shared renderers; the pinned compact renderer already validates the link and strips query strings/fragments. Remove the duplicate local evidence section from that compatibility path.

How verified

98 focused notification tests passed, with one existing event-loop deprecation warning. Ruff, documentation validation (0 blocking, 1 existing advisory) and git diff --check passed. An isolated execution of the original function reproduced the lost source cause and the compatibility branch's lost supplied URL. Gitleaks 8.30.1 on origin/main..HEAD: exit 0, 0 findings. Central publication-check was unavailable locally; no central-checker result is claimed.

Why

Operators need the existing safe cause code and supplied run evidence to investigate a blocked cycle. The generic blocked_run classification alone discarded known causes. A missing or unsafe source URL still remains unavailable; no console route or unrelated monitor run is invented.

Risk

Notification presentation only. Existing classification, incident identities, routes, runtime targets, orders, execution gates and risk decisions remain unchanged. No deploy paths or cloud resources were modified. Source work began after the separate warm recovery writer finished. This PR does not resolve the independent runtime failures or deploy any change.

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Review exact head 44c38e643b4ab4d5f2d5e2a6a28f7f3ced0edfbc against 826c9fbf49f86da4cce8ae424c68b95bdd7fbac8. Scope: three files only. Verify the closed cause-code allowlist, pinned shared renderer compatibility, URL privacy and unchanged classification/routing/incident identity. 98 focused notification tests passed. This is source-only; the separate recovery workflow and runtime gates are excluded.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T05:21:44.806208Z 3fb55e0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 44c38e643b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi marked this pull request as ready for review November 6, 2026 05:19
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 6, 2026 — with ChatGPT Codex Connector

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Review exact post-sync head 3fb55e0f1c1d7c7f77330053c29994301450f6ee against main 75006aa6042707224ee83b588e904c08a4581ccf. The previous CLEAN for 44c38e643b4ab4d5f2d5e2a6a28f7f3ced0edfbc is stale and is not acceptance for this head. Main was merged without conflicts; the three notification files are unchanged by synchronization. Scope remains docs/unified-daily-notification.md, notifications/unified_adapter.py, and tests/test_attention_source_evidence.py. Verify cause-code allowlisting, pinned shared renderer compatibility, supplied URL privacy, and unchanged classification/routing/incident identity. Gitleaks and git diff --check passed after sync. Merge-only authority: t1272u/t1273u and standing t1236u/t1270u; agent-approved only, no owner confirmation or override. No deploy or runtime recovery.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 3fb55e0f1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi merged commit d7e1ddf into main Nov 6, 2026
15 of 18 checks passed
@Pigbibi
Pigbibi deleted the fix/preserve-attention-source-evidence branch November 6, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant