Repository navigation
fix: Preserve source evidence in attention notifications - #980
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review Review exact head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review Review exact post-sync head |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AI assistance
Implemented with OpenAI Codex (GPT-6). Request independent review from the configured Codex integration on this exact head.
What changed
Retain allowlisted execution block causes in incident attention messages instead of replacing them with the broad incident kind. Pass existing started_at and console_run_url fields to both supported shared renderers; the pinned compact renderer already validates the link and strips query strings/fragments. Remove the duplicate local evidence section from that compatibility path.
How verified
98 focused notification tests passed, with one existing event-loop deprecation warning. Ruff, documentation validation (0 blocking, 1 existing advisory) and git diff --check passed. An isolated execution of the original function reproduced the lost source cause and the compatibility branch's lost supplied URL. Gitleaks 8.30.1 on origin/main..HEAD: exit 0, 0 findings. Central publication-check was unavailable locally; no central-checker result is claimed.
Why
Operators need the existing safe cause code and supplied run evidence to investigate a blocked cycle. The generic blocked_run classification alone discarded known causes. A missing or unsafe source URL still remains unavailable; no console route or unrelated monitor run is invented.
Risk
Notification presentation only. Existing classification, incident identities, routes, runtime targets, orders, execution gates and risk decisions remain unchanged. No deploy paths or cloud resources were modified. Source work began after the separate warm recovery writer finished. This PR does not resolve the independent runtime failures or deploy any change.