Skip to content

fix: Activate minimum-zero adoption replacements before health - #978

Merged
Pigbibi merged 3 commits into
mainfrom
fix/activate-adopt-replacement
Nov 5, 2026
Merged

Pigbibi merged 3 commits into
mainfrom
fix/activate-adopt-replacement

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

AI assistance

Authored with Codex (GPT-6). Independent exact-head review by the official Codex GitHub integration: completed for 417b0d4 with no findings or unresolved findings.

What changed

Activate the minimum-zero cleanup replacement with warm=99% / replacement=1%, assert the exact pair, require strict fresh startup health, then promote replacement=100%. Bind the waiter's minimum-zero exception to the exact source revision and retain generation, identity, image, spec, continuity and traffic checks. Stop failed or ambiguous second-stage activation without rollback or replay.

Keep unreferenced fake replacements Retired without ContainerHealthy. Add real-waiter regressions for ordering, absent/False/Unknown health, failed and ambiguous splits, interruption, drift, and restart refusal. Confirm that an actual original-serving minimum-zero baseline remains valid; service-level minimum zero cannot substitute for revision-level minimum zero. Document recovery authorization bounds.

How verified

  • Reproduced the old lifecycle failure with the cold replacement fake and real bounded waiter before the fix.
  • Focused lifecycle, shared-tag adoption and waiter suites: 139 passed.
  • Final local suite: 6580 passed, 6 skipped, 368 subtests passed; only two unrelated macOS baseline cases deselected after reproducing both at the unchanged base (non-executable scanner/Bash behavior and /var versus /private/var temporary paths).
  • Exact-head Linux CI: 6582 passed, 6 skipped, 368 subtests passed with no exclusions; isolated TQQQ offline-risk job passed.
  • Ruff, protected workflow shell contract, Cloud Run startup validation (11 routes), documentation check and Gitleaks directory/commit-range scans passed. Documentation check reports one existing README outline advisory.
  • No cloud deployment or runtime verification performed.

Why

Cleanup previously waited for an unreferenced, minimum-zero replacement's ContainerHealthy before assigning any traffic, so it could never observe that replacement start.

Risk

High: deployment lifecycle and health qualification. This source change adds a second explicit temporary 99/1 traffic effect when executed under separate exact-target approval. No production action, deployment retry, traffic mutation, Secret/IAM/Scheduler change or execution/risk-switch change is authorized by this PR. The existing lifecycle creates a new pair; it does not resume an interrupted pair. Workflow/operator github.sha and application source_commit are pinned independently; the standard workflow rebuilds an image and cannot reuse an existing image digest/replacement. Failed cleanup still requires separately authorized recovery.

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the complete diff at head c8b9cc1 against base 24a35a3. Focus on explicit replacement activation before strict health, exact minimum-zero exception binding, second-split failure/ambiguous outcomes without rollback or replay, original-serving minimum-zero baseline, and preserved identity/digest/spec/generation/traffic checks. All cloud effects in tests are fake. This is source-only work; no deployment or recovery attempt is authorized.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T21:01:42.422080Z 417b0d4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Codex <noreply@openai.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: c8b9cc1658

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Pigbibi commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the final complete candidate at head d96b5d2 against base 24a35a3. The earlier exact-head review completed without findings. The new commit documents the independently pinned workflow/operator github.sha and application source_commit, and that the standard image workflow builds a new image/revision pair rather than reusing a retained digest/replacement. Please bind the resulting review state to this current head. No cloud action is authorized.

Co-Authored-By: Codex <noreply@openai.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: d96b5d26c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Pigbibi commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Final exact-head acceptance review: head 417b0d4, base 24a35a3. Both preceding code/doc candidates were reviewed without findings. The final test-only commit updates shared shortened-tag consumers to authorize and assert the cleanup-only 99/1 split while preserving no initial split and restart refusal. All 139 focused lifecycle/tag/waiter tests pass. Two macOS-only baseline failures reproduced at the unchanged base; Linux CI remains full and unmodified. Please cover the complete diff and bind the provider review state to this final head. No cloud action or retry is authorized.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 417b0d44f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 5, 2026 — with ChatGPT Codex Connector
@Pigbibi
Pigbibi marked this pull request as ready for review November 5, 2026 20:59
@Pigbibi
Pigbibi merged commit 8aa8e8e into main Nov 5, 2026
17 of 22 checks passed
@Pigbibi
Pigbibi deleted the fix/activate-adopt-replacement branch November 5, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant