Repository navigation
fix: Activate minimum-zero adoption replacements before health - #978
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review Please review the complete diff at head c8b9cc1 against base 24a35a3. Focus on explicit replacement activation before strict health, exact minimum-zero exception binding, second-split failure/ambiguous outcomes without rollback or replay, original-serving minimum-zero baseline, and preserved identity/digest/spec/generation/traffic checks. All cloud effects in tests are fake. This is source-only work; no deployment or recovery attempt is authorized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Codex <noreply@openai.com>
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review the final complete candidate at head d96b5d2 against base 24a35a3. The earlier exact-head review completed without findings. The new commit documents the independently pinned workflow/operator github.sha and application source_commit, and that the standard image workflow builds a new image/revision pair rather than reusing a retained digest/replacement. Please bind the resulting review state to this current head. No cloud action is authorized. |
Co-Authored-By: Codex <noreply@openai.com>
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Final exact-head acceptance review: head 417b0d4, base 24a35a3. Both preceding code/doc candidates were reviewed without findings. The final test-only commit updates shared shortened-tag consumers to authorize and assert the cleanup-only 99/1 split while preserving no initial split and restart refusal. All 139 focused lifecycle/tag/waiter tests pass. Two macOS-only baseline failures reproduced at the unchanged base; Linux CI remains full and unmodified. Please cover the complete diff and bind the provider review state to this final head. No cloud action or retry is authorized. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AI assistance
Authored with Codex (GPT-6). Independent exact-head review by the official Codex GitHub integration: completed for 417b0d4 with no findings or unresolved findings.
What changed
Activate the minimum-zero cleanup replacement with warm=99% / replacement=1%, assert the exact pair, require strict fresh startup health, then promote replacement=100%. Bind the waiter's minimum-zero exception to the exact source revision and retain generation, identity, image, spec, continuity and traffic checks. Stop failed or ambiguous second-stage activation without rollback or replay.
Keep unreferenced fake replacements Retired without ContainerHealthy. Add real-waiter regressions for ordering, absent/False/Unknown health, failed and ambiguous splits, interruption, drift, and restart refusal. Confirm that an actual original-serving minimum-zero baseline remains valid; service-level minimum zero cannot substitute for revision-level minimum zero. Document recovery authorization bounds.
How verified
Why
Cleanup previously waited for an unreferenced, minimum-zero replacement's ContainerHealthy before assigning any traffic, so it could never observe that replacement start.
Risk
High: deployment lifecycle and health qualification. This source change adds a second explicit temporary 99/1 traffic effect when executed under separate exact-target approval. No production action, deployment retry, traffic mutation, Secret/IAM/Scheduler change or execution/risk-switch change is authorized by this PR. The existing lifecycle creates a new pair; it does not resume an interrupted pair. Workflow/operator github.sha and application source_commit are pinned independently; the standard workflow rebuilds an image and cannot reuse an existing image digest/replacement. Failed cleanup still requires separately authorized recovery.