Repository navigation
fix: Start untagged warm candidates with an approved micro split - #976
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ade649140
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
added
the
owner-approved
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
removed
the
owner-approved
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review Please review the complete current head 1aa0efe, including the retained zero-percent-tag P2 correction and its regression tests, shared tag-policy callers, and the merge of current main. Peer4 is explicitly excluded from this PR's service scope. This is a source-only change; any deployment or redeployment requires a separate owner card. Do not deploy or change Secret/IAM. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
added
the
agent-approved
ChatGPT Codex Connector
AI assistance
Codex (host-configured model). Independent review is requested from the established Codex GitHub integration for the complete current head.
Problem and change
Preserve the exact-target candidate warmup lifecycle and adopt the versioned
cloud-run-tags/v1local helper across existing operator callers. Tags fit the exact service name's combined 46-character budget, shorten deterministically when possible, and refuse occupied tags. A tag-impossible warmup requires an exact-service approval for its temporary 99/1 split; strictly no-traffic probes refuse that lifecycle. Existing identity, strict startup health, routing, restoration and no-replay checks remain required.The P2 zero-percent-tag finding was fixed in the existing follow-up commit: split validation considers nonzero entries while common validation still checks every route. Its regression tests preserve an existing zero-percent tag through the real waiter. The original thread is resolved on that evidence. Current main was merged normally without conflicts.
Service scope and authority
Peer4 is explicitly excluded from this PR's service scope. This is source-only engineering work under t1270u/t1236u. No deployment, redeployment, service activation, Secret/IAM change, force push or production change is authorized. Any later deployment needs a separate owner card specifying the exact service, revision and permitted actions.
Use
agent-approvedonly after the fresh exact-head Codex review is clean and the non-label required checks are green. Do not useowner-approved. Record clearance and squash merge in the approvals ledger under t1270u.Validation
Acceptance head:
1aa0efee3711797364ca71b9ad7ebfe999865373; base:5dc7c7dc456542df71f9eec6adf9ee6af2a98938. Fresh Codex marker:status=completed,has_unresolved_findings=false; unresolved threads: 0. All seven required checks passed before squash merge. Hosted offline suite: 6555 passed, 6 skipped, 368 subtests passed; isolated TQQQ job: success. Local changed-file Gitleaks scan: 15 files, zero findings; protected workflow shell contract, documentation check (0 blocking, 1 existing advisory) andgit diff --check: passed. Local dependencies installed successfully; the full pytest result above is hosted CI evidence.Risk
High: operator lifecycle and deployment paths. No dependency pin, production binding, runtime target inventory or protected trading switch changes. Local claims are not distributed locks; existing cloud read/compare checks are not atomic Cloud Run CAS. Source acceptance does not establish runtime adoption.