Repository navigation
fix: Recompute account drawdown before risk admission - #968
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58af1e1e03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review current head |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review exact head The snapshot portfolio projection now preserves drawdown observation time. Regression: 4 failed before the fix; focused suites: 162 passed after. Full suite: 6,366 passed, 6 skipped, 368 subtests passed. Existing P1/native/cache tests remain green. Publication checker publication-check/2.0-advisory (build 2947dd7867b4): exit 0, advisory; 2533 full-tree matches / 2410 matching lines. Phase-2 style check: 0 blocking, 1 existing README advisory. No deployment or runtime acceptance is claimed. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AI assistance
Codex (configured worker model gpt-6.1-sol) authored the cache repair and offline validation. Independent acceptance belongs to the established review-and-merge bot; previous review findings remain historical until the new exact head is reviewed.
What changed
Refresh stale drawdown caches from current account NAV/peak while preserving valid native explicit drawdown and native peak-only arithmetic. A 7.5% artificial reduce case previously sold zero shares because cache recomputation replaced the native
.075float with a smaller binary64 value; it now sells exactly five, matching main. Native.2remains bit-equal.Keep metadata/nested cache values separate from the native measurement during rebuilds. Existing timestamped fallback retains its measurement provenance and expiry check. UNKNOWN still uses the unavailable-observation gate, and measured breaches retain the persistent breaker behavior. No sizing function or threshold changes.
The complete PR contains the earlier cache regressions and necessary r4 measurement fixtures. This follow-up changes only the adapter and adds native compatibility tests; existing fixtures and expected values are untouched by this repair.
How verified
.075fake sell test..2, volatility and peak-only controls. Another 16 corrected-cache cases match main given an independently fresh explicit current measurement. This does not claim stale inputs have unchanged results or universal equivalence for every input.6ad9627e588bfe474fa14130fb03af948f74d03e, run over the entire candidate tree: 0 blocking, 1 existing README advisory, exit 0. Repository style check reports the same result..075sizing failure and two.2precision failures; they are not three pre-existing.075failures. Blame and adjacent good/bad bisect identify initial PR commit58af1e1e03623d4abec054b493a9eb05884fb0cbas introducing the committed.075regression. The two historical.2failures were already corrected in r4. No failure is waived as pre-existing.Why
The cache repair must not replace current native measurements or change main's sizing boundary behavior. Keeping source provenance prevents cache values from gaining native precedence after rebuild.
Risk
High: account risk adapter. Existing malformed/missing measurement, stale-cache, timestamp, journal/restart and switch-off tests remain green. Bit equality is limited to the stated comparison matrix. Existing required native checks and review gates remain intact. No merge, deployment, labels, production switches, credentials, IAM or Gateway operations are part of this change.
Publication check
Shared checker
publication-check/2.0-advisory, build2947dd7867b4: 2533 total findings, 2410 matching lines on the complete tracked candidate tree and offline probe; advisory scan completed. No real credential was identified in this repair. The central checker result is recorded above.First 20 matches (masked text):