Skip to content

fix: Adopt shared Cloud Run tag preflight - #524

Merged
Pigbibi merged 2 commits into
mainfrom
feat/cr-tag-helper-adopt-r1
Nov 5, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
feat/cr-tag-helper-adopt-r1

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

AI assistance

OpenAI Codex, using the model configured by the job runner.

What changed

Adopt the versioned cloud-run-tags/v1 preflight contract at the Firstrade diagnostic, sync-plan and retained Cloud Build boundaries. Invalid exact names and insufficient fixed cbd tag headroom now stop before planning or staging. The image-only build path checks service syntax without allocating a tag. Preserve the diagnostic constants consumed by other inspection scripts, and retain MIT provenance.

The upstream QPK Draft was unavailable at adoption, so this uses the brief's bounded versioned local-copy fallback: only the shared version, 46-character budget and headroom function are copied verbatim. No runtime dependency pin changes or allocation/traffic APIs are introduced.

How verified

  • Adverse baseline: 14 failed / 5 passed; whitespace-identity follow-up: 2 failed / 1 passed. Corrected cases pass after implementation.
  • Focused caller suite: 107 passed.
  • Full Python suite: 1840 passed, 118 subtests passed, one upstream deprecation warning.
  • Ruff, documentation check (0 blocking; existing README-outline advisory), public runtime-configuration scan and package build passed.
  • Dot review offline contracts: 11 passed. Installed-lock shared import contract: 3 passed. Locked QPK consistency check: all 3 dependency files match. Lock and installed dependency checks passed.
  • The supplementary legacy latest-main QPK checker reports two pre-existing pin differences; CI's locked-source check passes. Both dependency files remain identical to base.

Why

Owner decision t1255s7222, Option B from the cr-service-name-inventory-r1 decision memo and generator inventory, authorizes this bounded caller adoption. Service renames remain deferred. Fixed cbd diagnostics refuse incompatible names and retain their zero-traffic contract.

Risk

Protected deployment tooling is affected. This Draft does not merge, deploy, dispatch a workflow, change traffic, rename services or change IAM, Secrets, variables, live trading, Kelly or stop-loss switches. Offline validation does not prove deployed adoption or current cloud ownership. Existing diagnostic baseline/identity/ownership/readback gates remain required.

Central publication check (advisory)

Checker: publication-check/2.0-advisory; build 83d9d1130377; findings: 1153; matching lines: 1148. Owner rule pt1114u treats the result as advisory; no CI enforcement is changed.

First 20 masked matches (file:line and masked text):

.<PROJECT_ID>/CODEOWNERS:4: /.env.example @<PROJECT_ID>
.<PROJECT_ID>/CODEOWNERS:5: /.github/CODEOWNERS @<PROJECT_ID>
.<PROJECT_ID>/CODEOWNERS:6: /.github/workflows/ @<PROJECT_ID>
.<PROJECT_ID>/CODEOWNERS:7: /application/execution_receipt_adapter.py @<PROJECT_ID>
.<PROJECT_ID>/CODEOWNERS:8: /application/execution_service.py @<PROJECT_ID>
.<PROJECT_ID>/CODEOWNERS:9: /application/paper_execution_admission.py @<PROJECT_ID>
.<PROJECT_ID>/CODEOWNERS:10: /application/paper_execution_command_consumer.py @<PROJECT_ID>
.<PROJECT_ID>/CODEOWNERS:11: /runtime_execution_policy.py @<PROJECT_ID>
.<PROJECT_ID>/CODEOWNERS:12: /scripts/execution_report_heartbeat.py @<PROJECT_ID>
.<PROJECT_ID>/dot-review/review.cjs:106:   const token = <REDACTED> core.getIDToken(audienceText); // Exact bytes; URL normalization may change an audience.
.<PROJECT_ID>/dot-review/review.cjs:190:   const <PROJECT_ID> = {...pr,head:{...pr.head,sha:pair.target},base:{...pr.base,sha:pair.base}};
.<PROJECT_ID>/dot-review/review.cjs:191:   const binding = {...b.binding({repository:trust.repo.full_name,pr:<PROJECT_ID>,policyCommit:trust.commit,files},trust.policySha),
.<PROJECT_ID>/dot-review/test-review.cjs:81:   const content='<PROJECT_ID> source\n', sourceSHA='d'.repeat(40);
.<PROJECT_ID>/dot-review/test-review.cjs:82:   const pr={number:7,changed_files:1,commits:1,title:'<PROJECT_ID> change',body:'<PROJECT_ID> body',
.<PROJECT_ID>/dot-review/test-review.cjs:100:     assert.equal(audience,'https://audience.example.test');return '<PROJECT_ID>-only';},summary};
.<PROJECT_ID>/dot-review/test-review.cjs:111:         task={id:'<PROJECT_ID>-task',owner:'example/repo',provider:'dot',revision:1,status:'running',request,output:null,artifacts:[]};
.<PROJECT_ID>/workflows/diagnose-cached-stage-failure.yml:52:   GCP_PROJECT_ID: <PROJECT_ID>
.<PROJECT_ID>/workflows/diagnose-cached-stage-failure.yml:53:   GCP_WORKLOAD_IDENTITY_PROVIDER: projects/<PROJECT_NUMBER>/locations/global/workloadIdentityPools/<PROJECT_ID>-actions/providers/<PROJECT_ID>-main
.<PROJECT_ID>/workflows/diagnose-cached-stage-failure.yml:54:   GCP_WORKLOAD_IDENTITY_SERVICE_ACCOUNT: firstrade-platform-deploy@<PROJECT_ID>.iam.gserviceaccount.com
.<PROJECT_ID>/workflows/diagnose-cached-stage-failure.yml:69:       id-token: <REDACTED>

@Pigbibi

Pigbibi commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T20:07:25.296078Z 1229ac3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: f652873774

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi marked this pull request as ready for review November 5, 2026 20:05
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 5, 2026 — with ChatGPT Codex Connector
@Pigbibi
Pigbibi merged commit 5b8a9cf into main Nov 5, 2026
14 of 16 checks passed
@Pigbibi
Pigbibi deleted the feat/cr-tag-helper-adopt-r1 branch November 5, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant