Repository navigation
Conversation
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add invocation-local archive scanned/eligible/read/attributable counts and fixed exclusion counts. Unknown or truncated reads preserve null attribution totals; successful empty listings produce measured zeros. SDK read failures expose only allowlisted operation/category labels and suppress provider text. Receiver payload and publication gates are unchanged.
Stack
Depends on Draft #520. Base branch: fix/dry-run-exception-receipt-r1 at 86427ce. Candidate: e084769. Six diagnostic files only relative to that base. Do not merge out of order.
Validation and baseline-red publication exception
Owner t1234s7059 A authorizes this ordered Draft publication under t1233s7013 A. Exact original baseline: 576e533. Python 3.12.15, unchanged frozen lock, explicit original sibling-source paths.
Fresh receipt base: 18 failed, 1479 passed, 21 errors, 118 subtests passed. Stacked candidate: 18 failed, 1487 passed, 21 errors, 118 subtests passed. Exact failed/error identities match: introduced=0, retained=39 classified missing-shared-module environment failures. Full suite remains RED. The original dry-run receipt integrity failure is fixed by #520 and is absent from this candidate. Focused regression checks: 51 passed, 13 subtests passed. Ruff/whitespace passed; documentation check has zero blocking and one existing README advisory.
The earlier frozen-installed receipt baseline suite stopped after 160.19 seconds in urllib3 handling, 1097 passed, exit 2: INCOMPLETE, never PASS. No green frozen candidate full suite is claimed. Publication exception is valid only for these exact candidates/base/tree/environment and invalidates on drift. Required native checks are unchanged; this is not merge/deploy authority.
Risk and self-review
Retained fail-before tests exercise safe categories, suppression of private provider text, unknown counts on failure, and measured empty counts; all pass now. Counts use current invocation reads. No persisted state or cross-process writer is introduced. No trading gate, dependency, risk workflow, Secret or IAM change. Real SDK runtime behavior and deployed adoption remain unverified.
AI disclosure
Prepared with OpenAI Codex (GPT-6 family; exact model managed by host).
Central publication check
publication-check/2.0-advisory, build 83d9d1130377, advisory exit 0; total findings 1155, matching lines 1150. Existing tree findings are advisory. First 20 masked matches:
@codex review