Skip to content

fix: Preserve failed dry-run exception receipts #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pigbibi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Preserve failed dry-run exception receipts #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions application/execution_receipt_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,16 @@ def attach_unknown_failure_execution_receipt(report: dict[str, Any]) -> dict[str
if _is_legacy_unattested(report):
return report

outcome, confirmation = resolve_execution_receipt_fact(
dry_run=bool(report.get("dry_run")),
submission_attempted=True,
failed=True,
)
if report.get("dry_run"):
# An escaped exception is a failure even when no broker call is possible.
# Keep this fact independent of the shared resolver's dry-run precedence.
outcome, confirmation = "failed", "not_applicable"
else:
outcome, confirmation = resolve_execution_receipt_fact(
dry_run=False,
submission_attempted=True,
failed=True,
)
return attach_runtime_execution_receipt(
report,
outcome=outcome,
Expand Down
6 changes: 6 additions & 0 deletions tests/test_execution_receipt_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,12 @@ def test_dry_run_never_claims_submission(self) -> None:

self.assertEqual(report["execution_receipt"]["outcome"], "no_action")

def test_live_exception_preserves_submission_uncertainty(self) -> None:
report = _report()
attach_unknown_failure_execution_receipt(report)
self.assertEqual(report["execution_receipt"]["outcome"], "failed")
self.assertEqual(report["execution_receipt"]["broker_confirmation"], "not_observed")

def test_dry_run_exception_is_failed_without_live_submission_uncertainty(self) -> None:
report = _report()
report["dry_run"] = True
Expand Down
Loading