Repository navigation
fix(security): Add approved P09 rule-specific path allowlists - #42
Merged
Merged
Conversation
Contributor
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the P09 FIXTURE_OR_FALSE_POSITIVE findings under owner approval t1198s6751 option A. Only
.gitleaks.tomlchanges.Why
The findings documented by
p09-gitleaks-fullhistory-r2/out/allowlist-proposal.txtrequire rule-specific path exceptions. The generic rule was inherited, so an incomplete local override would be invalid.Changes
generic-api-keyrule, including its description, regex, entropy, keywords and all four default allowlists (including stopwords), without modifying the upstream block.json-credential-fieldrule.[extend] useDefault = trueand every existing setting.Testing
config/gitleaks.toml. The complete copied rule block is byte-identical to that source.scan-secrets.py dircheck: zero findings.git diff --check: pass.Risk and rollback
Path exceptions suppress future findings for the named rule and exact paths, including a real credential introduced there. Other rules remain active. Absolute-path directory scans do not match the anchored repository-relative exceptions. The shared workflow pins an earlier helper commit; this configuration PR does not update that pin or establish deployed adoption. Revert this configuration change to remove the exceptions. Keep Draft for the established review-and-merge bot.
Breaking changes
None.
Checklist
AI assistance
Codex, GPT-6.1 (sol host).
Publication check
Checker
publication-check/2.0-advisory, build2947dd7867b4, advisory exit 0; total matches 35, matching lines 35. These are advisory matches, not credential findings. First 20 masked entries: