feat: add resolve_error to StatusTrait - #968
Open
paolostivanin wants to merge 1 commit into
Open
paolostivanin wants to merge 1 commit into
paolostivanin wants to merge 1 commit into
Conversation
A dock error such as water_empty (38) stays latched on the device until
it is resolved in the app, even after the tank has been refilled.
Add StatusTrait.resolve_error(), which sends resolve_error with dict
params {"error_code": N} and refreshes the status. Without an explicit
code it resolves the current dock error, else the current robot error.
Array params are rejected by the firmware with -10007 (see Python-roborock#834).
Also add a resolve-error CLI command.
Verified on a Qrevo Master (roborock.vacuum.a117, fw 02.29.48): dock
error water_empty went back to ok within a second.
Closes Python-roborock#702
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dock errors such as
water_empty(38, clean water tank empty) stay latched on the device until "Resolved" is tapped in the Roborock app, even after the tank has been refilled. There was no way to clear them from the library or from Home Assistant.Changes
StatusTrait.resolve_error(error_code=None)sendsresolve_errorwith dict params{"error_code": N}and then refreshes the status. Without an explicit code it resolves the current dock error, falling back to the current robot error, and sends nothing when there is no error.resolve-error --device_id X [--error_code N]CLI command.Testing
On a Qrevo Master (
roborock.vacuum.a117, fw 02.29.48,shell_3_dock), I reproduced the error by lifting the clean water tank and sendingapp_start_wash. The robot reportedclear_water_box_hoare(38), and 30 s later the dock reportedwater_empty(38). After putting the tank back,resolve_errorwith{"error_code": 38}cleareddock_error_statusback tookwithin a second.Array-style params are rejected by the firmware with
-10007 invalid params(see #834), so this uses a dict.Closes #702