Skip to content

fix: honour --set-dtstart together with --set-due - #80

Open
tobixen wants to merge 2 commits into
masterfrom
fix/edit-dtstart-and-due
Open

tobixen wants to merge 2 commits into
masterfrom
fix/edit-dtstart-and-due

Conversation

@tobixen

@tobixen tobixen commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Commit message:

fix: honour --set-dtstart together with --set-due

edit sets DUE with move_dtstart=True, which keeps the old duration.  If
--set-dtstart was applied first, the DTSTART that had just been set was
shifted by that duration (19:00 on 23 October became 18:00 on
7 October).  Now DTSTART is applied after DUE.

Prompt: [plann edit --set-parent ... --set-dtstart "2026-10-23 19:00" --set-due "2026-10-23 20:00" set DUE right but DTSTART to 2026-10-07 18:00] dig into it

Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>

Also piggy-backing: fix: skip event children when completing a task (unrelated, a regression from #76 - completing a task with a scheduled event as its child crashed).

edit sets DUE with move_dtstart=True, which keeps the old duration.  If
--set-dtstart was applied first, the DTSTART that had just been set was
shifted by that duration (19:00 on 23 October became 18:00 on
7 October).  Now DTSTART is applied after DUE.

Prompt: [plann edit --set-parent ... --set-dtstart "2026-10-23 19:00" --set-due "2026-10-23 20:00" set DUE right but DTSTART to 2026-10-07 18:00] dig into it

Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Completing a task whose children include an event (or journal)
crashed with "'Event' object has no attribute 'is_pending'", as the
auto-completion of children from
#76 assumed every child is a
task.  Non-task children have nothing to complete and are skipped.

Prompt: The task has UID:50511558-eaec-11ef-9d3f-1c1bb5134174 and it is a VTODO, but still: (traceback pasted: AttributeError: 'Event' object has no attribute 'is_pending' in _complete, after answering "complete" in the one-by-one prompt) (when doing `plann interactive  manage-tasks`)

Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant