Repository navigation
URL property and VirtualLocation description support - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19.
URL and VirtualLocation's description were both dropped entirely by this converter, so I added both. URL became a links entry with no rel, since RFC 8984 doesn't define a rel value for a plain calendar URL. The description turned out to live somewhere I hadn't touched yet: not on CONFERENCE itself, but on a separate VCONFERENCE component correlated to it by URI, so I had to read and write that component too. While I was in there I picked up descriptionContentType as well, since STYLED-DESCRIPTION's FMTTYPE gets parsed either way to pick the right source, and it's a field the draft added specifically for this VCONFERENCE case even though RFC 8984 itself doesn't have it.
Cyrus rejects VirtualLocation.description outright with invalidProperties, on both create and update. Stalwart round-trips it fine.
I also found that a VEVENT with more than one URL line, or more than one VCONFERENCE sharing a CONFERENCE's URI, is undefined by the spec and wasn't handled. Both now keep the first and log a warning, matching how this file already treats a repeated RRULE.