Upgrade Purchasely SDK to 6.2.0

[chouaibMo]

Summary

Moves Shaker (Android + iOS) to the published Purchasely SDK 6.2.0, fixes the bugs found in a code review, and adds the 6.1 / 6.2 features a customer demo needs.

The branch no longer depends on local SDK builds: no mavenLocal(), no local SPM shim, no .worktrees/ios-develop symlink. A clean checkout builds on both platforms.

SDK 6.2.0

Android

• io.purchasely:core / google-play 6.2.0 from Maven Central; mavenLocal() removed from both settings files.
• compileSdk / targetSdk 36 (required by the 6.2.0 AAR metadata).
• Removed the obsolete io.purchasely.ext.interceptAction import.

iOS

• Remote Purchasely-iOS package, exactVersion: 6.2.0; ios/LocalPackages/ deleted.
• onClose → onCloseRequested; presentation finishers keyed by ObjectIdentifier instead of the internal presentation.id.
• ShakerTests builds in Swift 5 language mode: Xcode 16.4 (CI) rejects try await super.setUp() in Swift 6 mode. The app target stays on Swift 6 with complete strict concurrency.

Bug fixes

• Consent after a cold start (Android + iOS): revoked consent purposes were applied only when Settings opened, so the SDK tracked again after each launch. They are now applied when the SDK start succeeds and after a restart.
• Premium after login (Android): login with refresh = false showed a premium user as free. Premium is now refreshed after login and logout.
• PENDING purchase in Observer mode (Android): it counted as a success. It now reports Error("Purchase pending").
• Replayed purchase results (Android): PurchaseManager used replay = 1, so a new collector got an old result. Now replay = 0 with a suspending emit, so live collectors still get every result.
• Deeplink on rotation (Android): the deeplink was handled again after a configuration change. Now only on first creation.

New demo features

• Custom events (6.2 Purchasely.emit): recipe_viewed {recipe_id, spirit}, favorite_added, surprise_me on both platforms, cocktail_mixed on Android. They are the triggers for Console campaigns.
• Web redemption (6.1): listener (Android) / delegate (iOS) registered at start; the SDK shows its own alert; premium is refreshed on success.

Test plan

• Android: 12 selected unit tests, written first (RED: 8 assertion failures), then GREEN, incl. the 3 existing PurchaseManager delivery tests.
• iOS: 4 selected unit tests, written first (RED: 6 failures), then GREEN.
• ./gradlew :app:assembleDebug and xcodebuild build (iOS Simulator) pass.
• CI "Build & Test Android" passes.
• CI "Build & Test iOS" on the latest commit.
• Device smoke: paywall display, Observer and Full purchase, restore, web redemption.
• Campaign journey: recipe_viewed → campaign paywall, also after a restart with Campaigns consent revoked.

Known gap: no test drives the real app start for the consent fix (ShakerApp.onConfigured, AppViewModel start). A test needs Robolectric or a new seam; the helper and restart paths are tested.

Console prerequisites (Shaker app, not done by this PR)

The code uses items that are not configured in the Shaker Console yet:

• Placements filters, favorites, recipe_detail.
• Custom events recipe_viewed, favorite_added, surprise_me, cocktail_mixed.
• One campaign triggered by recipe_viewed.

Follow-up proposals (not in this PR)

• iOS promotional offers: move to the token-aware signPromotionalOffer(purchaseContextToken:) overload.
• iOS: StoreKit 2 in Full mode (today .storeKit1).
• iOS: wire Config.xcconfig with a checked-in defaults file, so the API key is not hard-coded.
• Android: remove the fallback signing password from build.gradle.kts.
• Apply stored consent also after an offline start.
• "Why this screen" inspector (placement, audience, A/B test, campaign, flow ids) and a live event log.

🤖 Generated with Claude Code

[kherembourg]

CI note after Android v6 Presentation example update:

• Android job currently fails before compiling app code because io.purchasely:core:6.0.0 and io.purchasely:google-play:6.0.0 are not published to Maven Central/local Maven on GitHub Actions. Local verification passed with the v6 artifacts available in Maven local: cd android && ./gradlew :app:assembleDebug --quiet.
• iOS job currently fails in ios/LocalPackages/Purchasely/Shims/PLYLottieView.swift on missing PLYLogger; this PR update did not touch iOS per scope.

[kherembourg]

@greptileai review

[greptile-apps]

Greptile Summary

Migrates both Android and iOS integrations from Purchasely SDK v5 to v6, replacing the removed setPaywallActionsInterceptor/processAction pattern with typed interceptAction suspend handlers, switching presentation APIs from fetchPresentation/PLYPresentationProperties to the builder DSL with preload(), and updating deeplink and running-mode APIs throughout.

• Android: PurchaselyWrapper rewired around Purchasely.interceptAction<T> suspend lambdas bridged through awaitPendingResult; PurchaseManager.queryProductDetailsAsync updated for the Billing 8.x QueryProductDetailsResult shape; enum rename from PAYWALL_OBSERVER → OBSERVER with legacy storage migration.
• iOS: Parallel changes to PurchaselyWrapper and EmbeddedScreenBanner; handleObserverAction simplified to direct async/await on @MainActor; loadPresentation adds defensive post-preload callback re-assignment.
• mavenLocal() remains in settings.gradle.kts (tracked in the PR checklist for removal once 6.0.0 is on Maven Central).

Confidence Score: 4/5

Safe to merge with one fix — the iOS success payment screen may silently skip subscription refresh in some SDK builds.

The Android migration is thorough: interceptors, presentation loading, tests, and the enum rename are all consistent. The iOS side has a gap in showSuccessPaymentScreen — the defensive post-preload callback re-assignment applied carefully in loadPresentation is missing here, which means refreshAfterSuccessPayment won't be invoked when the SDK build doesn't propagate builder-seeded callbacks. Users who successfully purchase will see stale premium state until they manually restart the app.

ios/Shaker/Purchasely/PurchaselyWrapper.swift — specifically the showSuccessPaymentScreen method.

Important Files Changed

Filename	Overview
ios/Shaker/Purchasely/PurchaselyWrapper.swift	iOS v6 migration: switches to builder DSL, typed interceptors, and async/await observer flow. loadPresentation defensively re-assigns presentation callbacks after preload, but showSuccessPaymentScreen omits this, leaving refreshAfterSuccessPayment unreachable when builder-seeded callbacks don't fire.
android/app/src/main/java/com/purchasely/shaker/purchasely/PurchaselyWrapper.kt	Core v6 migration: replaces setPaywallActionsInterceptor + processAction with typed interceptAction suspend handlers bridged through awaitPendingResult; updates SDK init, deeplink, and presentation APIs.
android/app/src/test/java/com/purchasely/shaker/purchasely/PurchaselyWrapperTest.kt	Tests updated to match the new suspend-based interceptor API; async/await-style interceptJob pattern correctly resolves pending results and cleans up after each test.
android/app/src/main/java/com/purchasely/shaker/data/purchase/PurchaseManager.kt	Updated queryProductDetailsAsync callback to accept the Billing 8.x QueryProductDetailsResult wrapper and extract productDetailsList from it; minimal and correct.
android/app/src/main/java/com/purchasely/shaker/data/PurchaselySdkMode.kt	Renames PAYWALL_OBSERVER to OBSERVER and adds LEGACY_PAYWALL_OBSERVER migration constant; fromStorage correctly handles both old and new storage values.
ios/Shaker/Purchasely/EmbeddedScreenBanner.swift	Replaces removed PresentationView property with a UIViewControllerRepresentable wrapper around PLYPresentationViewController; clean and correct.
android/settings.gradle.kts	Adds mavenLocal() as a temporary dependency resolver for the pre-release Purchasely 6.0.0 SDK; must be removed before merging (explicitly tracked in PR checklist).

Sequence Diagram

sequenceDiagram
    participant SDK as Purchasely SDK v6
    participant IW as interceptAction lambda
    participant PW as PurchaselyWrapper
    participant PM as PurchaseManager
    participant App as App / ViewModel

    Note over SDK,App: Observer-mode purchase flow (v6)
    SDK->>IW: intercept(.purchase) [suspend]
    IW->>PW: handlePurchase(info, action)
    PW->>PW: awaitPendingResult
    PW->>PM: purchaseRequests.emit(PurchaseRequest)
    PM->>PM: Google Play Billing purchase
    PM->>PW: "transactionResult.emit(Success|Cancelled|Error)"
    PW->>PW: pendingResult.invoke(PLYInterceptResult)
    PW-->>IW: PLYInterceptResult (resume continuation)
    IW-->>SDK: return result

    Note over SDK,App: Presentation display flow (v6)
    App->>PW: loadPresentation(placementId)
    PW->>SDK: "PLYPresentation{}.preload()"
    SDK-->>PW: PLYPresentation
    PW->>PW: re-assign onClose/onDismissed defensively
    PW-->>App: FetchResult.Success(handle)
    App->>PW: display(handle, activity)
    SDK-->>PW: PLYPresentationOutcome
    PW->>PW: toDisplayResult()
    alt pendingSuccessfulPurchase
        PW->>PW: showSuccessPaymentScreen()
    end
    PW-->>App: DisplayResult

Loading

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
ios/Shaker/Purchasely/PurchaselyWrapper.swift:351-376
**`showSuccessPaymentScreen` skips the defensive callback re-assignment done in `loadPresentation`**

`loadPresentation` explicitly re-assigns `presentation.onClose` and `presentation.onDismissed` on the loaded presentation object after `preload`, with the comment "builder-seeded callbacks are not fired by all develop snapshots." `showSuccessPaymentScreen` only attaches `onDismissed` on the builder; if the SDK snapshot in use doesn't propagate builder callbacks to the loaded presentation, the `refreshAfterSuccessPayment` call is never reached — subscriptions remain stale after the success screen is dismissed. The defensive re-assignment of `presentation.onDismissed` should be added inside the `preload` closure here, mirroring the pattern in `loadPresentation`.

_{Reviews (3): Last reviewed commit: "fix: block SDK default flow on Observer-..." | Re-trigger Greptile}

[Copilot]

Pull request overview

This PR migrates Shaker’s Android + iOS Purchasely integrations to Purchasely SDK v6, updating running modes, deeplink handling, action interception, and presentation fetching/display APIs, plus adjusting Android Billing for the transitive Billing v8 upgrade.

Changes:

• Android: upgrade Purchasely to 6.0.0, migrate to v6 Presentation APIs + typed interceptors, and adapt Billing queryProductDetailsAsync usage.
• iOS: migrate Purchasely initialization + deeplink + presentation flows to v6 APIs, and introduce a local Swift package wrapper for Purchasely sources.
• Tooling/docs: add temporary mavenLocal() resolution, update Gradle wrapper, and add a migration write-up.

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
settings.gradle.kts	Adds mavenLocal() to resolve Purchasely v6 artifacts temporarily.
android/settings.gradle.kts	Adds mavenLocal() for Android-only build resolution.
android/gradle/wrapper/gradle-wrapper.properties	Updates Gradle wrapper distribution URL.
android/gradle/libs.versions.toml	Bumps Purchasely + Billing versions and adjusts test dependency versions.
android/build.gradle.kts	Updates plugin aliases applied across Android build.
android/app/build.gradle.kts	Updates app module plugins and test dependencies; removes explicit Kotlin options.
android/app/src/main/java/com/purchasely/shaker/purchasely/PurchaselyWrapper.kt	Migrates to v6 DSL init, typed interceptors, Presentation preload/display APIs, and updated callback types.
android/app/src/main/java/com/purchasely/shaker/purchasely/PresentationHandle.kt	Re-anchors PLYPresentation import to v6 presentation package.
android/app/src/main/java/com/purchasely/shaker/data/RunningModeRepository.kt	Updates observer mode mapping for v6 running mode naming.
android/app/src/main/java/com/purchasely/shaker/data/PurchaselySdkMode.kt	Renames/migrates SDK mode storage/labels to “Observer/Presentation Observer”.
android/app/src/main/java/com/purchasely/shaker/data/purchase/PurchaseManager.kt	Adapts to new Billing v8 QueryProductDetailsResult.productDetailsList.
android/app/src/main/java/com/purchasely/shaker/ui/screen/settings/SettingsViewModel.kt	Renames paywall flows to presentation flows for onboarding placement.
android/app/src/main/java/com/purchasely/shaker/ui/screen/settings/SettingsScreen.kt	Updates UI wiring to new presentation display flows and observer naming.
android/app/src/main/java/com/purchasely/shaker/ui/screen/home/HomeViewModel.kt	Renames paywall triggers/callbacks to presentation equivalents.
android/app/src/main/java/com/purchasely/shaker/ui/screen/home/HomeScreen.kt	Updates presentation collection + dismissal callback wiring.
android/app/src/main/java/com/purchasely/shaker/ui/screen/favorites/FavoritesViewModel.kt	Renames paywall triggers/callbacks to presentation equivalents.
android/app/src/main/java/com/purchasely/shaker/ui/screen/favorites/FavoritesScreen.kt	Updates presentation collection + unlock action wiring.
android/app/src/main/java/com/purchasely/shaker/ui/screen/detail/DetailViewModel.kt	Renames paywall triggers/callbacks to presentation equivalents; updates comments.
android/app/src/main/java/com/purchasely/shaker/ui/screen/detail/DetailScreen.kt	Updates presentation collection + unlock action wiring.
android/app/src/test/java/com/purchasely/shaker/purchasely/PurchaselyWrapperTest.kt	Updates tests for v6 interceptor + presentation types and new suspend-based interception model.
android/app/src/test/java/com/purchasely/shaker/data/RunningModeRepositoryTest.kt	Updates tests for v6 observer mode mapping.
android/app/src/test/java/com/purchasely/shaker/data/PurchaselySdkModeTest.kt	Updates tests for v6 running mode mapping.
ios/Shaker/Screens/Settings/SettingsViewModel.swift	Updates stored running mode from .paywallObserver to .observer.
ios/Shaker/Screens/Onboarding/OnboardingScreen.swift	Avoids fetching onboarding presentation if onboarding is already completed.
ios/Shaker/Purchasely/PurchaselyWrapper.swift	Migrates initialization, deeplinks, action interceptors, and presentation preload/display to v6 APIs.
ios/Shaker/Purchasely/EmbeddedScreenBanner.swift	Replaces removed embedded view property with a UIViewControllerRepresentable wrapper.
ios/Shaker/Data/RunningModeRepository.swift	Updates stored running mode mapping to .observer.
ios/Shaker/Data/PurchaselySDKMode.swift	Maps app “paywall observer” selection to v6 .observer running mode.
ios/project.yml	Switches Purchasely dependency to local package and adjusts test strict concurrency setting.
ios/LocalPackages/Purchasely/Package.swift	Adds local SPM package wrapper definition for Purchasely sources.
ios/LocalPackages/Purchasely/Shims/Exports.swift	Adds exported imports shim for Purchasely sources in SPM.
ios/LocalPackages/Purchasely/Shims/PLYLottieView.swift	Adds Swift shim for PLYLottieView to avoid mixed ObjC/Swift target issues in SwiftPM.
docs/migration_v6.md	Adds a repo-specific migration guide for Purchasely v6 (Android + iOS).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[kherembourg]

Addressed the review findings across 97d74a9 (tests + data) and f801a15 (interceptors). Note: the Android suite isn't runnable in CI yet (io.purchasely:core:6.0.0 isn't on Maven Central), so the test fixes were verified by inspection against the actual enum shape.

#	Finding	Disposition
1	PurchaselySdkModeTest references removed PAYWALL_OBSERVER + stale storageValue/label assertions (compile error)	Fixed 97d74a9 — all refs → OBSERVER, storageValue→"observer", label→"Presentation Observer". Also fixed a second stale ref the report missed: SettingsViewModelTest.kt:296 (same compile error).
2	RunningModeRepositoryTest asserts persisted "paywallObserver" but setter writes "observer"	Fixed 97d74a9 — assertion → "observer", test renamed.
3	PurchaselySdkMode "pay" + "wallObserver" split literal	Fixed 97d74a9 — named LEGACY_PAYWALL_OBSERVER = "paywallObserver" constant.
4	RunningModeRepository LEGACY_OBSERVER branch is dead code	Fixed 97d74a9 — branch + constant removed; fromStorage() already maps "observer" and legacy "paywallObserver" to OBSERVER.
5	mavenLocal() must be removed before merging to main	Kept (tracked) — 6.0.0 isn't on Maven Central yet, so removing it breaks the build now. Tracked in the PR checklist; inline threads left open as the pre-merge reminder.

Additional Copilot findings also addressed inline:

• Observer-mode interceptor returns (Android + iOS): cancellation / ignored-duplicate now return SUCCESS/.success instead of NOT_HANDLED/.notHandled, so the SDK no longer runs its own purchase flow (v6 equivalent of v5 processAction(false), per docs/paywall-observer-reference.md). Fixed in f801a15.
• Kotlin plugin removal: intentional — AGP 9.2.1 ships built-in Kotlin (verified :app:compileDebugUnitTestKotlin is registered). Not a break.
• iOS forced StoreKit 1 and local SPM symlink: documented pre-release accommodations; left open for visibility, same as mavenLocal().

---

Generated by Claude Code

[kherembourg]

@greptileai review

---

Generated by Claude Code

[kherembourg]

@greptileai review

[greptile-apps]

Automatic reviews are disabled for this repository.