Repository navigation
fix(workflows): Fix production release workflow - #299
Merged
Merged
Conversation
SSM AWS-RunShellScript runs as root without HOME set, so the first command (git config --global) failed with "fatal: $HOME not set" and blocked every production release. Restore what #292 dropped and what deploy-staging.yml still does: export HOME for the deploy user, load NVM, and restart pm2 as that user. Closes #298
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
 |
github-actions
Bot
changed the title
Ayush8923
reviewed
Oct 30, 2026
Comment on lines
+66
to
+75
| REMOTE_CMD="export HOME=/home/$ROOT_USER \ | ||
| && export NVM_DIR=/home/$ROOT_USER/.nvm \ | ||
| && . \$NVM_DIR/nvm.sh \ | ||
| && git config --global --add safe.directory $BUILD_DIRECTORY \ | ||
| && cd $BUILD_DIRECTORY \ | ||
| && git fetch origin --tags --prune \ | ||
| && git checkout $DEPLOY_SHA \ | ||
| && npm ci \ | ||
| && npm run build \ | ||
| && pm2 restart $APP_NAME" | ||
| && sudo -iu $ROOT_USER pm2 restart $APP_NAME" |
Collaborator
There was a problem hiding this comment.
maybe replace this with this:
REMOTE_CMD="export HOME=/root \
&& git config --global --add safe.directory $BUILD_DIRECTORY \
&& cd $BUILD_DIRECTORY \
&& git fetch origin --tags --prune \
&& git checkout $DEPLOY_SHA \
&& npm ci \
&& npm run build \
&& pm2 restart $APP_NAME"
Per review, keep the deploy running as root and set HOME=/root so git config --global works, instead of switching to the deploy user. Drop the ROOT_USER env, NVM setup and sudo pm2 restart.
vprashrex
force-pushed
the
fix/prod-deploy-home
branch
from
October 30, 2026 06:55
54c3630 to
087c06d
Compare
Ayush8923
approved these changes
Oct 30, 2026
|
🎉 This PR is included in version 0.6.1-main.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #298
Summary
The production release workflow fails at "Wait for SSM command to finish" with
fatal: $HOME not set, sov0.6.0never reached production. Production is still onv0.5.0.SSM
AWS-RunShellScriptruns as root without$HOME. The first remote command,git config --global --add safe.directory ..., needs$HOMEto find the global git config, so it exits with code 128 before anything is deployed.This PR adds
export HOME=/rootat the start of the remote command in.github/workflows/create-release.yml. The rest of the deploy stays as #292 left it:git fetch --tags+git checkout $DEPLOY_SHA,npm ci,npm run buildandpm2 restart, all running as root.Checklist
npm run devandnpm run buildin the repository root and test.Notes
npmandpm2are on root's PATH on the production host, and that the app is registered in root's pm2. Before chore(deployment): Improve build process #292, production loaded NVM from the deploy user's home and ransudo -iu <user> pm2 restart. If the next release fails atnpm ciorpm2 restart, that setup is what's missing.v0.6.0workflow won't pick this up, because a tag runs the workflow file from its own commit. After this merges, cutv0.6.1frommain.