Repository navigation
fix: limit custom message previews to escaped body - #332
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom Matrix message previews currently fall through to Rust debug formatting, which can expose protocol fields in room/reply previews. Show only the HTML-escaped message body for every custom message and preserve the existing username prefix.
The regression tests check exact escaping and generated independence from private custom payload fields, including an empty-body regression seed. Independent source/spec review found no issues. The release workspace suite passed 709 tests with five existing ignored tests. Release app build, release workspace Clippy, static UX gate, typos, Cargo patch guard, and full spec guard passed. The active contract passed 13/13 checks and the encryption capability passed 7/7, with no skips or uncertain results in either.
This changes only the preview rule and its tests/contract; timeline approval controls and authenticated submission paths are unaffected.
Remote CI: all 13 checks passed on
8fe8de476c5c77e34a56484226305304cac2b3d3, including Linux, Windows, macOS, iOS and Android builds.