Repository navigation
chore: Bump github.com/ccoveille/go-safecast to 2.0.1 - #17
Conversation
Signed-off-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
|
Welcome @ccoVeille! It looks like this is your first PR to Project-HAMi/mock-device-plugin 🎉 |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the go-safecast dependency to its v2 major version and aligns the codebase with the new Go module import path.
Changes:
- Bump
github.com/ccoveille/go-safecastfromv1.8.2togithub.com/ccoveille/go-safecast/v2 v2.0.1 - Update the Go import path to use
/v2 - Refresh
go.sumentries for the new module version
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/pkg/api/device/device.go | Updates the go-safecast import path to the v2 module path. |
| go.mod | Upgrades the go-safecast dependency to v2.0.1 using the Go modules major-version path. |
| go.sum | Replaces v1 checksums with v2 checksums for go-safecast. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Old PRs and issues are being closed because they are no longer relevant. Or it was closed because of the |
|
Please reopen. The v2 version of go-safecast is yhe version you should target. The v2.0.1 is still ghe current one. v1.8 used by the module is no longer maintained |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, ccoVeille The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ccoVeille 3875889+ccoVeille@users.noreply.github.com
Note: I'm go-safecast creator and maintainer.
The v2 has breaking changes for something you were not using.
You can read https://github.com/ccoVeille/go-safecast/releases/tag/v2.0.0 if you are interested.