Repository navigation
feat: link pages with mentions and keep images inside notes - #44
Merged
Merged
Conversation
AmrMsCLL
force-pushed
the
feat/note-history
branch
from
October 5, 2026 19:04
8632470 to
55991d2
Compare
AmrMsCLL
force-pushed
the
feat/note-links
branch
from
October 5, 2026 19:04
8d91332 to
b769401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PR 3f from
.claude/.Plans/as2026-10-02-strata-phase-3-technical-design.md. Stacked on #43.New frontend dependencies:
@tiptap/extension-mention,@tiptap/suggestionand@tiptap/extension-image, 3.31.4, all MIT and part of the Tiptap core Amr approved. Installed in the Linux container; the lockfile changes are the new entries, plusoptionalflags dropped on packages that are now direct dependencies.@and two characters searches pages, tasks, events and anything else you can open, through the existing search;@Title, and clicking it opens what it points to.item_linksof kindmention, removes the ones you deleted, and only links items the writer can read, so a mention can never reveal someone else's page;attachmentlink from the note to the file;Verification
Lint, both builds and
tsc --noEmitpass.test/integration/notes.spec.tsadds a case covering:All five notes cases and
records.spec.tspass against Postgres on the local stack.test/notes.spec.tsxadds a case for "Linked from", which shows mentions only and links each item to its page.On the real local stack: typing "See @pack" in a new page listed the earlier page found by its text; Enter inserted the mention, and
item_linksgot thementionrow.Pasting an image wasn't tried in the browser, because it needs a real clipboard. The server side of attachments is covered by the integration test.