feat: rework the desktop shell, settings, loading and error states - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Amr's UI pass for Strata, on graphite-ui 0.3.0 (graphite-ui#11). The lockfile changes only the graphite-ui entries.
LoadError);CrashBoundary, reset on navigation);Verification
Lint,
tsc -bandvite buildpass locally against the published 0.3.0, and the settings, dashboard, tokens, skeletons, routes and tasks specs were rerun against it.Every frontend spec file was run and passes: activity, agenda, api, dashboard, files, forms, invitations, local-data, quick-add, routes, search, settings, share, skeletons, spaces, subscriptions, tasks, tidy, tokens and two-step.
New tests:
Tests updated for the new labels and controls:
They check the same behaviour as before.
Checked in a local browser against a mock API at 1440 px: the sidebar toggle and alignment, every sidebar icon, Home, Settings and Tidy titles all at 121 px, and the header buttons rendering their icons at one height. Not checked at phone width.