Skip to content

fix: keep the page gutter beside the sidebar - #8

Merged
AmrMsCLL merged 1 commit into
mainfrom
fix/app-shell-sidebar-gutter
Oct 1, 2026
Merged

AmrMsCLL merged 1 commit into
mainfrom
fix/app-shell-sidebar-gutter

Conversation

@AmrMsCLL

@AmrMsCLL AmrMsCLL commented Oct 1, 2026

Copy link
Copy Markdown
Member

What changed

When AppShell has a sidebar, main was the flex item that filled the row. flex-1 then overrode the shell width, so the page lost its side margins: it touched the screen edge on phones and the sidebar on desktop. A wrapper is now the flex item, and main keeps the shell width and centring.

Found while running Strata's first build on a local stack at 375 px and on desktop.

Verification

  • The AppShell spec now checks that main sits inside the wrapper, keeps shell and has no flex-1.
  • npm run lint, npm test (33 tests) and npm run build pass.

Checklist

  • The change is focused and contains no credentials or generated secrets.
  • Documentation and tests were updated when behavior changed.
  • Deployment or rollback considerations are described when relevant. Nothing deploys; 0.2.1 follows.

With a sidebar, the main element was also the flex item that filled the row, so flex-1 replaced
the shell width and the page lost its side margins on phones and next to the sidebar on desktop.
The row's flex item is now a wrapper, and main keeps the shell width and margins.
@github-actions github-actions Bot added the size/s 11-50 changed lines, excluding lockfiles label Oct 1, 2026
@AmrMsCLL
AmrMsCLL merged commit 904f145 into main Oct 1, 2026
4 checks passed
@AmrMsCLL
AmrMsCLL deleted the fix/app-shell-sidebar-gutter branch October 1, 2026 23:00
@AmrMsCLL AmrMsCLL mentioned this pull request Oct 1, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s 11-50 changed lines, excluding lockfiles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant