Repository navigation
fix: keep the page gutter beside the sidebar - #8
Merged
Merged
Conversation
With a sidebar, the main element was also the flex item that filled the row, so flex-1 replaced the shell width and the page lost its side margins on phones and next to the sidebar on desktop. The row's flex item is now a wrapper, and main keeps the shell width and margins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When
AppShellhas asidebar,mainwas the flex item that filled the row.flex-1then overrode theshellwidth, so the page lost its side margins: it touched the screen edge on phones and the sidebar on desktop. A wrapper is now the flex item, andmainkeeps theshellwidth and centring.Found while running Strata's first build on a local stack at 375 px and on desktop.
Verification
mainsits inside the wrapper, keepsshelland has noflex-1.npm run lint,npm test(33 tests) andnpm run buildpass.Checklist