Repository navigation
docs: bring back the French documentation as translations of the current pages - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #18 rewrote the README and documentation in English and, in doing so, deleted the French originals (
docs/docs.md,docs/filebot_parity.md,docs/metadata_sources.md). Lin wanted the French kept. This brings it back, not as the old pages (which described the egui interface and a spec that no longer matches the code) but as French translations of the current English pages, kept honest by CI the same way Eidos does it.What changes
English, first. A few facts from the old French pages were still true and had not made it into the English:
docs/metadata-sources.md: per source, what KayaBot keeps from an answer (title, year field, what it uses as the source rating: TMDBvote_average/ 10, TheTVDB and TVmaze the searchscore, OMDb a fixed 0.7), and the published quotas (TMDB around 40 requests per second since the 2019 limit was dropped, TVmaze at least 20 calls per 10 seconds per IP, OMDb 1,000 requests a day on a free key), each checked against the service's current page. The old French TMDB figure (40 per 10 seconds) is out of date and was not carried over.docs/filebot-parity.md: collection folders, subtitle language suffixes and subtitle downloads, which the old French parity spec listed as FileBot features to cover.docs/architecture.md: the French release tags (VF,VOSTFR) the title clean-up removes.README.md: a short## Languagesection linking the French pages.French translations under
docs/i18n/fr/, which mirrors the repository root:docs/i18n/fr/README.mddocs/i18n/fr/docs/architecture.mddocs/i18n/fr/docs/metadata-sources.mddocs/i18n/fr/docs/filebot-parity.mdInterface labels use the wording of
src/i18n/fr.json(Renommer, Recherche, Associer, Simulation, Connexions...). Anchors point at the French headings, and links to files outside the docs (LICENSE,.env.example, the release page) are rewritten for the deeper path.Checks, copied unchanged from Project-Colony/Eidos:
scripts/i18n-check.sh(each translation'seidos-i18nstamp must matchgit hash-objectof its English source, and the headings, code fences and table rows must match) andscripts/i18n-links.py(every markdown link and anchor resolves). A newtranslations up to datejob inci.ymlruns both, with the same pinnedactions/checkoutas the other jobs. The stamp keeps theeidos-i18nname so the scripts stay byte for byte the same as Eidos's.Both pass locally:
4 translation(s) checkedand10 markdown file(s) checked, every link resolves.When an English page changes, its translation now goes stale and CI says so: re-translate and run
./scripts/i18n-check.sh --fix, or delete the translation.