Repository navigation
ci: install Rust with rustup in the CI and release workflows, as the Resources templates now do - #20
Merged
Merged
Conversation
…Resources templates now do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the third-party
dtolnay/rust-toolchainaction from every workflow and installs Rust withrustup, which every GitHub-hosted runner image already carries. This follows Project-Colony-Resourcestemplates/sign-and-publish-caller.ymlanddesign/dependencies.md("In CI, install Rust with rustup"): one less action pin to keep current, and that action publishes no versions Dependabot could move.Changes
release.yml, build job: the template'sInstall Ruststep, verbatim (rustup toolchain install stable --profile minimal --no-self-update,rustup default stable,rustup target add ${{ matrix.target }},shell: bash). Adding the target is a no-op on native legs and required on the Intel macOS leg. This was the only functional drift from the current template.ci.yml, check job (Linux, macOS, Windows):rustup toolchain install stable --profile minimal --component clippy,rustfmt --no-self-updatethenrustup default stable, withshell: bashso the same step runs on the Windows leg.ci.yml, MSRV job:rustup toolchain install "$RUSTUP_TOOLCHAIN" --profile minimal --no-self-update.RUSTUP_TOOLCHAINstill pins every cargo invocation, and therustc --versionguard still fails the job if the pin stops working. The comment no longer refers to the removed action.Swatinem/rust-cachestays inci.ymlonly; the release build stays uncached.No Rust code changes.
Verification
dtolnay/rust-toolchainremains in the repository.ci.yml: fmt, clippy and tests on the 3 OS, plus the MSRV build.release.ymlonly runs on a release tag; its new step is the Resources template step, the same rustup commands Project-Colony-Resources runs in its own CI and release workflows.