Repository navigation
Restore MediaWiki:Maps after a failing config-save test and test the namespace check - #950
Merged
Merged
Conversation
…namespace check Follows-up to #949 `ConfigPageHooksTest` saves `MediaWiki:Maps` on the wiki's real database, so a failing run left the invalid test config as the wiki's live configuration. A save that goes through is now undone before the assertions run. The test for other JSON pages changed namespace and title at once, so dropping the namespace half of the config-page check went unnoticed. It now uses a page named `Maps` in the GeoJson namespace. `MapPrinter` imports `MapsFactory`, and its tracking-category comment no longer claims for every caller what only holds for `#ask` and `#show`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up to #949
ConfigPageHooksTestsavesMediaWiki:Mapson the wiki's real database, so a failing run left the invalid testconfig as the wiki's live configuration. A save that goes through is now undone before the assertions run.
The test for other JSON pages changed namespace and title at once, so dropping the namespace half of the config-page
check went unnoticed. It now uses a page named
Mapsin the GeoJson namespace.MapPrinterimportsMapsFactory, and its tracking-category comment no longer claims for every caller what onlyholds for
#askand#show.