Skip to content

Restore MediaWiki:Maps after a failing config-save test and test the namespace check - #950

Merged
JeroenDeDauw merged 1 commit into
masterfrom
fix/config-page-test-hygiene
Oct 3, 2026
Merged

JeroenDeDauw merged 1 commit into
masterfrom
fix/config-page-test-hygiene

Conversation

@JeroenDeDauw

Copy link
Copy Markdown
Member

Follows-up to #949

ConfigPageHooksTest saves MediaWiki:Maps on the wiki's real database, so a failing run left the invalid test
config as the wiki's live configuration. A save that goes through is now undone before the assertions run.

The test for other JSON pages changed namespace and title at once, so dropping the namespace half of the config-page
check went unnoticed. It now uses a page named Maps in the GeoJson namespace.

MapPrinter imports MapsFactory, and its tracking-category comment no longer claims for every caller what only
holds for #ask and #show.

AI-authored — Claude Code, Opus 5.5 (max); findings from a /review session of #949, follow-up asked by @JeroenDeDauw; diff not yet human-reviewed; mutants checked: an unregistered hook fails the save test and leaves MediaWiki:Maps unchanged, a dropped namespace check fails the renamed test; PHPUnit, phpcs and PHPStan pass locally.

…namespace check

Follows-up to #949

`ConfigPageHooksTest` saves `MediaWiki:Maps` on the wiki's real database, so a failing run left the invalid test
config as the wiki's live configuration. A save that goes through is now undone before the assertions run.

The test for other JSON pages changed namespace and title at once, so dropping the namespace half of the config-page
check went unnoticed. It now uses a page named `Maps` in the GeoJson namespace.

`MapPrinter` imports `MapsFactory`, and its tracking-category comment no longer claims for every caller what only
holds for `#ask` and `#show`.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@JeroenDeDauw
JeroenDeDauw marked this pull request as ready for review October 3, 2026 19:21
@JeroenDeDauw
JeroenDeDauw merged commit 2cfead3 into master Oct 3, 2026
8 checks passed
@JeroenDeDauw
JeroenDeDauw deleted the fix/config-page-test-hygiene branch October 3, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant