You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Touches core BPMN script failure and retry paths; behavior change is limited to how exceptions are logged after errors, but affects all script task failures.
Overview
Fixes script task failure handling when the runner throws Illuminate\Http\Client\RequestException (e.g. non-2xx HTTP from script executors).
RunScriptTask no longer rebuilds the caught throwable with new $exceptionClass($message), which broke types whose constructors are not message-only. It now logs the original exception when the error-handling message is unchanged, and wraps a generic Exception with the prior throwable as previous when retries change the message (e.g. “failed after N attempts”).
Adds RunScriptTaskTest coverage: a 503 RequestException marks the token failing, records the HTTP error on the request, and respects BPMN error handling by re-queuing RunScriptTask with the configured attempt number and delay instead of failing immediately.
Reviewed by Cursor Bugbot for commit 6b69322. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Describe the issue this ticket solves and describe how to reproduce the issue (please attach any fixtures used to reproduce the issue).
Solution
How to Test
Describe how to test that this solution works.
Related Tickets & Packages
Code Review Checklist