Skip to content

fix(FOUR-33061): replace gettext _() with Laravel __() - #9029

Open
gproly wants to merge 2 commits into
developfrom
bugfix/FOUR-33061
Open

gproly wants to merge 2 commits into
developfrom
bugfix/FOUR-33061

Conversation

@gproly

@gproly gproly commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Avoid php-fpm SIGSEGV on macOS in 2FA, login, and password-expiry flows.

https://processmaker.atlassian.net/browse/FOUR-33061

Avoid php-fpm SIGSEGV on macOS in 2FA, login, and password-expiry flows.

https://processmaker.atlassian.net/browse/FOUR-33061
@cursor

cursor Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Mechanical translation-helper swap with no auth or business-logic changes; low regression risk aside from verifying locale files still resolve the same keys.

Overview
Replaces PHP gettext _() with Laravel’s __() for user-facing strings in login lockout, 2FA validation/session errors, forced password change / expiry messaging, script executor Docker image delete failures, and the 2FA email notification subject.

This aligns those paths with Laravel’s translation stack and addresses php-fpm SIGSEGV on macOS (FOUR-33061) tied to gettext in those flows. User-visible copy is unchanged; only the translation helper differs.

Minor non-functional edits: PHPDoc short type names (Closure, User, MailMessage), a trailing comma in a JSON error array, and whitespace in check2faByGroups.

Reviewed by Cursor Bugbot for commit a12e682. Bugbot is set up for automated code reviews on this repo. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants