Skip to content

Switches for on/off settings, one-line helper copy - #149

Merged
kevinkamto merged 6 commits into
mainfrom
ui/tighter-settings-copy
Nov 5, 2026
Merged

kevinkamto merged 6 commits into
mainfrom
ui/tighter-settings-copy

Conversation

@kevinkamto

@kevinkamto kevinkamto commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #148

  • Adds components/ui/switch.tsx (shadcn Switch, using the existing radix-ui dependency - no new package).
  • Transcript panel, mock hints, hide taskbar and allow screen capture rows use a Switch instead of a Checkbox. Row shape and click target are unchanged. Login's "Remember me" stays a checkbox.
  • Settings descriptions, onboarding step subtitles, suggestion-mode option text and the save-before-losing-work dialog bodies are cut to one sentence, in en.ts and ru.ts. Keys and signatures are unchanged.
  • Warnings that matter before enabling a setting stay visible: hide taskbar still says the window cannot be minimized and to relaunch if lost; screen capture still says shares and recordings will see the window.

Checks

  • pnpm lint
  • tsc (app + electron)
  • pnpm build
  • pnpm test:main (includes the ui-language test for Russian strings left in English)
  • Manual pass at 840x600 in English and Russian, light and dark: Configuration switches, onboarding steps, panel-header switches
  • Clear/Start/Stop save prompts with the shorter copy (not yet seen in the app)

🤖 Generated with Claude Code

Settings rows and save prompts carried multi-sentence helper text that
buried the controls. Instant-apply toggles now use a Switch, and the
descriptions are cut to one sentence in both locales.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gitar-bot

gitar-bot Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Gitar is working

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

Gitar

- Off track and thumb now contrast in both themes; stock tokens left
  the off state near-invisible in light mode.
- Panel auto-scroll checkboxes become small switches, matching the
  settings rows.
- Settings switches reference their description via aria-describedby.
- Restore the macOS Dock and the speakers consequence in copy, clarify
  the app-language step, shorten the remaining mock save prompts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kevinkamto

Copy link
Copy Markdown
Collaborator Author

Review follow-up:

  • Switch off-state contrast fixed in light mode (track muted-foreground/70, white thumb with shadow); dark checked thumb uses primary-foreground.
  • The four panel-header auto-scroll checkboxes are now Switch size="sm", matching the settings rows.
  • Settings switches carry aria-describedby pointing at their description.
  • Copy: hide-taskbar mentions the Dock again, the microphone step says why headphones matter, the app-language step is clearer, and the mock done/practise-again prompts match the other save prompts.

Lint, both tsc configs, build and pnpm test:main pass. Manual pass at 840x600 in light/dark and EN/RU still pending.

Language, suggestions, mock hints and transcript steps showed a subtitle
that restated the field's own helper line directly beneath it. Those
steps now carry only a title; the transcript step's title says what it
asks. Hide-taskbar helper no longer repeats its label.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kevinkamto

Copy link
Copy Markdown
Collaborator Author

Second review follow-up:

  • Setup wizard: the language, suggestions, mock-hints and transcript steps no longer show a subtitle that repeats the field's helper line underneath. The transcript step title is now "Show a live transcript?" instead of "One last thing".
  • Hide taskbar helper no longer repeats its label: "Also hides the Dock icon and keeps the window on top. It cannot be minimized - relaunch the app if it gets lost."

Lint, both tsc configs, build and pnpm test:main pass.

alpha5611331 and others added 2 commits November 5, 2026 14:27
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The taskbar helper told Windows users it hides a Dock icon. The wizard
column jumped sideways on the one step tall enough to scroll.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kevinkamto

Copy link
Copy Markdown
Collaborator Author

Manual pass in the running app at 840x600 (Windows), EN + RU, light + dark:

  • Configuration: switch on/off states are clearly distinguishable in both themes; Russian copy fits without bad wraps.
  • Setup wizard: steps without a subtitle read cleanly; Language, Suggestions, Mock hints, Zoom and Transcript checked.
  • Panel headers: small Auto-scroll switches align with their label in both themes.

Found and fixed in 551d7d8:

  • The taskbar helper told Windows users it hides a "Dock icon". Now: "Keeps the window on top (on macOS, the Dock icon is hidden too). It cannot be minimized - relaunch the app if it gets lost."
  • The wizard column shifted ~8px sideways on the Microphone step, the one tall enough to scroll. The scroll container now reserves the scrollbar gutter (scrollbar-gutter: stable).

Reserving the gutter on one side stopped the jump but left every step
7.5px left of centre. Reserve it on both edges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kevinkamto
kevinkamto merged commit d82ee9a into main Nov 5, 2026
1 check passed
@kevinkamto
kevinkamto deleted the ui/tighter-settings-copy branch November 5, 2026 20:40

@kevinkamto kevinkamto left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings and dialogs show too much helper text

2 participants