Repository navigation
feat(django): opt-in posthog-js cookie fallback for request context #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DanielVisca
wants to merge
7
commits into
main
Choose a base branch
from
posthog/django-posthog-js-cookie
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+392
−9
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a210c8a
feat(django): read the posthog-js cookie when tracing headers are mis…
DanielVisca 4efbf1a
fix(django): only read this project's posthog-js cookie and respect o…
DanielVisca 14a86be
fix(django): make the posthog-js cookie fallback opt-in and identity-…
DanielVisca b2f8c35
feat(django): allow a custom session idle timeout for the cookie fall…
DanielVisca 6aed973
fix(django): clamp the cookie session idle timeout like posthog-js
DanielVisca 0b00c2d
feat(django): honor opt-out by default for the cookie fallback
DanielVisca 697393f
fix(django): treat a zero cookie idle timeout as the default
DanielVisca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| pypi/posthog: minor | ||
| --- | ||
|
|
||
| The Django middleware can read the session ID, and the distinct ID of an identified user, from the posthog-js cookie when a request has no tracing headers, so backend events link to browser sessions on same-site requests without frontend configuration. Turn it on with `POSTHOG_MW_READ_POSTHOG_COOKIE = True`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When no middleware or module key is set,
_read_posthog_cookiechecks every project's consent cookie. A request with onlyph_projectA_posthogand__ph_opt_in_out_projectB=0therefore loses project A's distinct ID and session ID, even though the visitor opted out only of project B. This can drop browser-session links for apps that capture through an explicit client without settingPOSTHOG_MW_CLIENT.Keep the selected cookie's name and check consent only for that project.
Knowledge Base Used: Framework integrations
Prompt To Fix With AI