Repository navigation
fix(flags): retain tracking metadata in local evaluation snapshots - #1041
Open
dustinbyrne wants to merge 1 commit into
Open
dustinbyrne wants to merge 1 commit into
dustinbyrne wants to merge 1 commit into
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-10-08T21:09:23.309246+00:00 ✅ All Tests Passed!121/121 tests passed Capture_V1 Tests✅ 95/95 tests passed View Details
Capture_Ai Tests✅ 5/5 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
Feature_Flags_Local_Evaluation Tests✅ 4/4 tests passed View Details
|
Contributor
|
[Medium impact] The PR appears safe to merge; no actionable issues were found. Reviews (1) · Last reviewed commit: "fix(flags): retain tracking metadata in ..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
evaluate_flags()reads the minimal-event gate before first-use local definition loading. A newly loaded gated snapshot can therefore emit full$feature_flag_calledproperties. A definitions refresh during evaluation can also attach experiment metadata from a different generation than the evaluated value.Changes
This follows the sdk-specs point-in-time evaluation and minimal-event contracts. No public API, default, dependency, or flag-value behavior changes. Includes a
pypi/posthog: patchchangeset, also covering the generatedposthoganalyticsmirror.💚 How did you test it?
Posthogentry point passed with mocked transport and no live requests.📝 Checklist
.sampo/changesets/.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented and validated with Pi. A fresh read-only reviewer independently inspected the diff, affected callers, tests, specification contracts, and release scope. Validation used mocked transport; no live PostHog deployment was tested.