Repository navigation
Develop pybind controller for Python/agentic use cases - #1542
Merged
Merged
Conversation
The controller logged through global_logger_command_line(), which also prints every line to stdout. Python callers, and MCP servers that use stdio for their protocol, need stdout to stay clean. Log to global_logger_raw() instead; lines still reach every listener of the global logger, e.g. SerialProgramsCommandLine's log file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ntroller is ready Commands used to log "Controller is not ready." and silently do nothing, so a caller couldn't tell that its input was dropped. Throw InvalidConnectionStateException with the connection status instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
current_status() returned ControllerConnection::status_text(), which is formatted for the GUI: each line wrapped in <font color=...> tags, lines joined with <br>. Add ControllerConnection::raw_status_text(), which keeps the text of each status line as it was set (without colors) and joins the lines with a newline, and use it in current_status(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the pybind controller to:
current_status()returns plain text, not HTML text