Repository navigation
Updated Helioptile hunter - #1287
Conversation
|
Tests are failing on the button detectors. |
|
Why do you need to make a separate detector for the interior? It looks like we already have that here: Can you try to debug why that one isn't working? |
|
|
I got the tests to run locally and ran a debug for the detector. it is failing because it's not detecting the interior B in the hyperspace png. Would a "if interior returns false, check for the B button instead, and if both return false, return false" be ok? alternatively I can try detecting the right stick symbol at the top right or the travel spots icon as a 3rd point of confirmation for map open. |
Mysticial
added
PR: Doesn't work. Awaiting Fix.
R2 - Medium Risk
|
Converted to draft while I wait for confirmation of packages update and while I finalize code cleanup of mistakes I made |
|
All tests passed now. The new detector sees the fly spot icon and helioptile hunter now uses fast travel movement instead of blind timing based joystick commands to travel from place to place. I've also made the program indifferent to where or what time of day the player starts the program. |
c327076 to
59ce0c3
Compare
|
I just rebased and did a slight refactor of the MapDetector changes. So that part is good to go. But the Helioptile program is failing to detect this as sunny. Can you pull out the just the |
I'll do that and see what I can do for the screenshot provided. I didn't encounter this during my testing in game. |
Marked as draft because I don't really know how to to quickly do the split you're requesting. I'll research how best to do it in the coming days and make the necessary changes. |
e298b48 to
5238e67
Compare
Marked as ready for review. I still have not been able to replicate this issue, so I would need more information to do any additional testing or changes. I tested both my change to helioptile hunter and the weather finder program which both rely on the same weather detector functions. For the weather finder program, I looked for both clear and sunny weather. encountered no issue. For the hunter, I first changed the code to test only day and clear weather, no issues, and the program warped to wild zone 14 when appropriate. I then looked for only sunny and again the program warped to WZ 14 with no issues when appropriate. I tested on every capture card and switch I own (switch v1, v2, oled, and switch 2). |
|
Does the Sun detector work on the screenshot above? |
I'm not sure how to test just a screenshot. I had GPT help me create something that runs the weather detector on its own, and that suggests that weather detector doesn't work on the screenshot. Of course that's inconclusive IMO since it's the product of AI and the program finds the sunny weather on the real game. Here's an example of weather finder working just fine to find sunny weather. I tried running the weather finder program on the screenshot, but it also failed to detect that it was a screenshot of the map, so it may be that I the screenshot doesn't save properly for me too. The only way I was able to save kuro's nshot wwas by clicking on it on my phone and downloading it that way. On a browser I get this 
|
|
I tried my test program on the live game where I found the sunny weather and it does detect sunny. Score one for AI I suppose. so that narrows it down to something local to Kuro or my inability to get the screenshot properly. 
|
|
I'm preparing a refactor of the weather detector using waterfill instead of cropped template matching. It will need new resources to operate effectively so I will upload those first. |
5849176 to
dcb1a3f
Compare
Developer-Butters
changed the title
Updated the helioptile shiny hunter to use fast travel and day/night state detection to improve the function of the program. Update Helioptile, ButtonDetector, and MapDetector Added ButtonBInterior to button detector and used that as an improvement to the mapdetector. Tested Helioptile, Donut Maker, and Mega Shard Farmer to confirm that the updates to MapDetector did not cause harm.
Removed remnants of the ButtonBInterior attempt. Added comment to helioptile hunter to explain the hunt loop.
adjusted some formatting
Refined the ROI for MapDetector's FlySpotIcon. This adjustment should allow the CommandLineTests to pass. The loop counter wasn't working, so adjusted the logic to correctly stop after the requested loops.
Reverted to cycles instead of loops after some additional thought and rereading the wiki. Added clarification of what a cycle is in the UI.
…ed the include block.
… reverted to move_map_cursor to improve speed of the program, but added some wat time to ensure the move doesn't fire early.
…r to wildzoneentrance
dcb1a3f to
9443b7f
Compare
|
I'm testing a couple of final changes to this PR now that the new weather detector is merged. I will do a separate Weather detector PR for the 1080 comment left on #1319. With the next commit this change should be finalized and ready for review. ETA EOD 10/2/26. |
Merge upstream main, including the WeatherDetector refactor, into the Helioptile Hunter branch. End each hunting cycle after 65 completed loops or when unsuitable weather or nighttime is detected. Count shortened cycles toward the stop limit and update the cycle description. Add normal user logs for weather matches, day/night measurements, loop counts, bench attempts, and cycle completion reasons to support troubleshooting. Validation: Debug build passed; all 36 WeatherDetector tests passed. Five-cycle unattended Switch test passed.
|
updated cycle counting: each cycle now ends after 65 completed loops or when unsuitable weather/nighttime is detected. Validation:
Added weather and decision logging for troubleshooting. if it fails in the future, we can pinpoint the failure easier. |
| "<br>" | ||
| "<b>Cycle Definition:</b><br>" | ||
| "A cycle consists of entering Wild Zone 14 a total of at most 65 times. " | ||
| "A cycle ends after 65 entry loops or when unsuitable weather or nighttime is detected. " |
There was a problem hiding this comment.
What with this 65 and how is it related to the 32*30 limit below this?
There was a problem hiding this comment.
the PLZA day lasts ~65 entry loops. so after we bench sit to get to the morning we can do the gate fly entry 65 times before we need to force a reroll to the next morning.
The 32*30 is a maximum for the field and a hold over from the original code. I think it is a limit to how big of a number we can input in the cycle field. I only added the clarification comments here because I found the previous definition confusing and admittedly didn't review this coded maximum. I 'm guessing the original author copied this code block from gin's autofossil program.
I can do an additional commit to remove this limit if you want, but its not related to my updates. I also doubt anyone will put in a number bigger than a few hundred in this field anyone wanting ~1000 cycles will likely put 0 to run until they manually stop.
3 participants
Updated the helioptile shiny hunter to use fast travel and day/night state detection to improve the function of the program.
Added ButtonBInterior to button detector and used that as an improvement to the mapdetector.
Tested Helioptile, Donut Maker, and Mega Shard Farmer to confirm that the updates to MapDetector did not cause harm.