Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 817ded89bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
strobil
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
The existing
blockLookup(Block, LookupOptions)only searches at a specific block. This PR addsblockLookup(LookupOptions)for searches within a radius, across a world, or across all worlds. The new overload returns block breaks, placements, and interactions; entity events are handled separately byentityLookup. Both block overloads share the same lookup implementation.It also adds:
LookupOptions.world(World)for whole-world searches in spatial typed lookups.entityLookup(LookupOptions)returningEntityResult, withentityActions(List<EntityAction>),includeEntities(List<EntityType>), andexcludeEntities(List<EntityType>)filters.Entity lookups return spawn and kill events. Spawn events match either their original or persisted current/final location; results retain the original event coordinates.
Compatibility
Empty or omitted filters preserve each lookup’s default results. Material inclusion returns only matching block events; material exclusion leaves entity events unchanged in the existing block overload.
The last call to
world,location, orradiusdetermines the search area. Omitting all three searches across all worlds. The existingblockLookup(Block, LookupOptions)still uses the supplied block’s coordinates.The existing
blockLookup(Block, LookupOptions)retains entity events when no action or material-inclusion filter excludes them. Command and legacy lookups are unchanged.Approach
@Intelli, now that there’s a dedicated
entityLookup, would you be okay with the newblockLookup(LookupOptions)returning only block events, while keeping the existing overload unchanged for compatibility? Or would you prefer both block overloads to keep returning entity events too?