Rename report section Gantt Interactive to Gantt and add waterfall subtitle - #887
Merged
Conversation
The Gantt section now opens with the line 'Unoptimized waterfall. Parallel work not modelled here.' so readers do not mistake the schedule for an optimized plan. The note lives in the dhtmlx template body content, so it also appears in the standalone gantt.html. Adds a test for the dhtmlx export that checks the note sits at the top of the body content. Updates the docs mention of the section name. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…btitle The note now comes from ReportGenerator.append_html via a new optional subtitle argument, rendered as a plain paragraph the same way the Premortem intro line is. Putting it at the report layer means it shows up even when Luigi reuses a cached gantt.html from an earlier run, which is why it was missing from a regenerated report. Replaces the dhtmlx export test with tests for the subtitle in worker_plan/tests. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReportGenerator.append_htmlgains an optionalsubtitleargument that prepends an escaped paragraph to the embedded HTML. Doing this at the report layer rather than in the dhtmlx template means the note appears even when Luigi reuses a cached gantt.html from an earlier run.Verification
worker_plan/tests/test_report_generator.pycover the subtitle (present and ordered before the widget; absent by default). They failed before the change and pass after.test.py: 401 tests, only the 23 pre-existing mcp_cloud errors that need PostgreSQL.ruff check --select=E9,F63,F7,F82 .clean.🤖 Generated with Claude Code