Repository navigation
feat(map-editor): accept dominant-baseline and show repaired changes (PPT-2832) - #600
Merged
Merged
Conversation
GPT-6.1 sol adds dominant-baseline="middle" to every label it inserts. The attribute was missing from the allowlist, so each such insert was rejected even though its position was right. Testing on placeos-dev on 21 Oct lost 4 of 4 labels on both runs. The value is limited to the SVG 2 keywords plus text-before-edge and text-after-edge. The ops schema description lists it, and rest-api carries the same file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Deployment failed for project frontend-templates with the following error: Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit |
…rect (PPT-2832) rest-api now asks the model once more when it rejects some of an answer's ops, and records the outcome as `repair` on the job. The proposal card says how many rejected changes were corrected that way, so a reviewer knows the proposal is the model's second attempt. Nothing is shown when the second answer was not used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
camreeves
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editor side of PlaceOS/rest-api#458, from testing map editing on placeos-dev on 21 Oct with five models.
1. Accept
dominant-baselineon AI-edited text. GPT-6.1 sol addsdominant-baseline="middle"to every label it inserts. The attribute wasn't on the allowlist, so every one of those inserts was rejected even though the positions were right: 4 of 4 labels, twice. Its value must be one of the SVG 2 keywords ortext-before-edge/text-after-edge.ops-schema.jsonis updated to match rest-api.2. Note repaired changes. rest-api now asks the model once more when it rejects some of an answer's ops, and records the outcome as
repairon the job. The proposal card shows "Rejected changes corrected automatically: N" when the second answer was used, and nothing otherwise.MapAIJob.repairis optional, so jobs from an older server are unaffected.Testing:
validate.spec.tscase:middlepasses,centreis rejected and locked. It fails without the allowlist entry.🤖 Generated with Claude Code