Repository navigation
refactor(map-editor): review follow-up on the AI map editor - #581
Merged
Merged
Conversation
The context builder and the snapshot renderer each worked out a mark's extent from its path points, box corners and arrow tip. Both now use annotationPoints() from annotations.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
Superseded: this commit was pushed straight to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review follow-up for the Codex half of the AI map editor UI, stacked on #570 (base
PPT-2832-ai-map-review).Change
annotationPoints()inai/annotations.tsnow works out the points a mark covers: its path, its box corners and an arrow's tip. The context builder, which decides whether a mark lies outside the map, and the snapshot renderer, which grows the picture to fit off-map marks, each had their own copy of that calculation. Behaviour is unchanged.Reviewed and left alone
view_boxgetter.<img>data URLs.Noted, not changed
buildProposalnow validates the full proposal and then the ticked subset, so every checkbox toggle runs validation twice, render check included. On the large Medibank maps that may be noticeable. Caching the full validation per job would remove it.Checks: map-editor tests (24 files, 292 tests) and lint pass.
🤖 Generated with Claude Code