feat(map-ai): generate SVG edit proposals for Concierge (PPT-2832)

shard.lock

@@ -223,7 +223,7 @@ shards:
 
   placeos-models:
     git: https://github.com/placeos/models.git
-    version: 9.119.5
+    version: 9.120.0
 
   placeos-resource:
     git: https://github.com/place-labs/resource.git

shard.yml

@@ -58,7 +58,7 @@ dependencies:
   # Database view
   placeos-models:
     github: placeos/models
-    version: ">= 9.5"
+    version: ">= 9.120"
 
   # An abstraction over Fibers
   promise:

spec/controllers/signage/signage_ai_providers_spec.cr

@@ -27,6 +27,7 @@ module PlaceOS::Api
         authority_id:  authority.id,
         credentials:   {api_key: "sk-spec-secret"},
         default_model: "gpt-image-2",
+        text_model:    "gpt-5.4-mini",
         is_default:    true,
       }.to_json
 
@@ -39,6 +40,7 @@ module PlaceOS::Api
       rendered = JSON.parse(result.body)
       rendered["provider"].as_s.should eq "OPENAI"
       rendered["is_default"].as_bool.should be_true
+      rendered["text_model"].as_s.should eq "gpt-5.4-mini"
 
       row = Model::SignageAIProvider.find!(UUID.new(rendered["id"].as_s))
       row.credentials_encrypted?.should be_true
@@ -51,6 +53,7 @@ module PlaceOS::Api
         authority: authority,
         name: "openai-#{random_name}",
         credentials: %({"api_key":"keep-me"}),
+        text_model: "gpt-5.4-mini",
       ).save!
 
       result = client.patch(
@@ -66,6 +69,12 @@ module PlaceOS::Api
       row.name.should eq "renamed"
       row.enabled.should be_false
       row.credentials_json["api_key"].as_s.should eq "keep-me"
+      # left out of the body, left alone
+      row.text_model.should eq "gpt-5.4-mini"
+
+      # sent empty, cleared
+      client.patch(File.join(base, provider.id.to_s), headers: Spec::Authentication.headers, body: {text_model: ""}.to_json).status_code.should eq 200
+      Model::SignageAIProvider.find!(provider.id.as(UUID)).text_model.should be_nil
     end
 
     it "lets support read, and nothing more" do
@@ -211,6 +220,58 @@ module PlaceOS::Api
         JSON.parse(result.body)["model"].as_s.should eq "gpt-image-2.5-sunburst"
       end
 
+      it "probes the text model with kind=text" do
+        authority = Model::Authority.find_by_domain("localhost").not_nil!
+        provider = Model::Generator.signage_ai_provider(
+          authority: authority,
+          name: "openai-#{random_name}",
+          text_model: "gpt-5.4-mini-custom",
+        ).save!
+        requests = [] of JSON::Any
+
+        HttpMocks.map_ai_vendor("OK", requests: requests)
+        HttpMocks.signage_ai_vendor_refused
+
+        result = client.post(File.join(base, provider.id.to_s, "test?kind=text"), headers: Spec::Authentication.headers)
+        result.status_code.should eq 200
+
+        body = JSON.parse(result.body)
+        body["ok"].as_bool.should be_true
+        body["model"].as_s.should eq "gpt-5.4-mini-custom"
+
+        requests.size.should eq 1
+        requests.first["model"].as_s.should eq "gpt-5.4-mini-custom"
+        requests.first["max_completion_tokens"].as_i.should eq SignageAIProviders::TEXT_PROBE_TOKENS
+        requests.first["response_format"]?.should be_nil
+        requests.first["reasoning_effort"].as_s.should eq "low"
+
+        client.post(File.join(base, provider.id.to_s, "test?kind=sound"), headers: Spec::Authentication.headers).status_code.should eq 422
+      end
+
+      it "reports a text probe that spent its budget without answering" do
+        authority = Model::Authority.find_by_domain("localhost").not_nil!
+        provider = Model::Generator.signage_ai_provider(authority: authority, name: "openai-#{random_name}").save!
+
+        HttpMocks.map_ai_vendor("", finish: "length")
+
+        body = JSON.parse(client.post(File.join(base, provider.id.to_s, "test?kind=text"), headers: Spec::Authentication.headers).body)
+        body["ok"].as_bool.should be_false
+        body["kind"].as_s.should eq "invalid_response"
+        body["error"].as_s.should contain "without answering"
+      end
+
+      it "reports a text probe that times out" do
+        authority = Model::Authority.find_by_domain("localhost").not_nil!
+        provider = Model::Generator.signage_ai_provider(authority: authority, name: "openai-#{random_name}").save!
+
+        HttpMocks.map_ai_vendor_timeout
+
+        body = JSON.parse(client.post(File.join(base, provider.id.to_s, "test?kind=text"), headers: Spec::Authentication.headers).body)
+        body["ok"].as_bool.should be_false
+        body["kind"].as_s.should eq "timeout"
+        body["model"].as_s.should eq MAP_AI_DEFAULT_OPENAI_MODEL
+      end
+
       it "reports a refusal as a moderation failure rather than an error" do
         authority = Model::Authority.find_by_domain("localhost").not_nil!
         provider = Model::Generator.signage_ai_provider(

spec/controllers/signage/signage_ai_spec.cr

@@ -1,45 +1,6 @@
 require "../../helper"
 
 module PlaceOS::Api
-  # Everything a signage AI request needs: somewhere to put the image, and a
-  # vendor to ask for one. Returns (authority, storage, provider).
-  def self.setup_signage_ai(quotas : Hash(String, JSON::Any) = {} of String => JSON::Any)
-    authority = Model::Authority.find_by_domain("localhost").not_nil!
-    storage = Model::Generator.storage(authority_id: authority.id.as(String)).save!
-    provider = Model::Generator.signage_ai_provider(
-      authority: authority,
-      name: "openai-#{random_name}",
-      is_default: true,
-      quotas: quotas,
-    ).save!
-
-    {authority, storage, provider}
-  end
-
-  # A signage group the caller may act in, hung off a root group.
-  def self.signage_group(authority, user, permissions : Model::Permissions)
-    root = Model::Generator.group(authority: authority).save!
-    group = Model::Generator.group(authority: authority, parent: root, subsystems: ["signage"]).save!
-    Model::Generator.group_user(user: user, group: group, permissions: permissions).save!
-    group
-  end
-
-  # Drive the long poll at `wait=0` until the job stops moving. The runner is a
-  # fiber in this same process, so each poll gives it a turn.
-  def self.await_signage_ai_job(base : String, id : String, headers : HTTP::Headers) : JSON::Any
-    path = File.join(base, "jobs", id)
-
-    100.times do
-      response = client.get(path, headers: headers)
-      response.status_code.should eq 200
-      body = JSON.parse(response.body)
-      return body if {"done", "failed", "cancelled"}.includes?(body["state"].as_s)
-      sleep 100.milliseconds
-    end
-
-    raise "signage AI job #{id} never reached a final state"
-  end
-
   describe SignageAI do
     base = SignageAI.base_route
 
@@ -77,8 +38,9 @@ module PlaceOS::Api
         _, _, provider = setup_signage_ai(quotas: {"user_per_day" => JSON::Any.new(5_i64)})
         user, headers = Spec::Authentication.authentication
 
-        # two candidates already spent today
+        # two candidates already spent today; map edits are a separate allowance
         Model::Generator.signage_ai_job(user: user, provider: provider, candidates: 2).save!
+        Model::Generator.signage_ai_job(user: user, provider: provider, candidates: 1, kind: Model::SignageAIJob::Kind::MapEdit).save!
 
         result = client.get(File.join(base, "capabilities"), headers: headers)
         result.status_code.should eq 200
@@ -298,6 +260,24 @@ module PlaceOS::Api
         JSON.parse(result.body)["kind"].as_s.should eq "quota"
       end
 
+      it "does not count map edit jobs against the image allowance" do
+        _, _, provider = setup_signage_ai(quotas: {"user_per_day" => JSON::Any.new(1_i64)})
+        user, headers = Spec::Authentication.authentication
+        Model::Generator.signage_ai_job(user: user, provider: provider, candidates: 1, kind: Model::SignageAIJob::Kind::MapEdit).save!
+
+        HttpMocks.signage_ai_vendor
+        HttpMocks.signage_ai_storage
+
+        result = client.post(
+          File.join(base, "generate"),
+          headers: headers,
+          body: {prompt: "a poster", candidates: 1}.to_json,
+        )
+
+        result.status_code.should eq 202
+        await_signage_ai_job(base, JSON.parse(result.body)["id"].as_s, headers)["state"].as_s.should eq "done"
+      end
+
       it "records a vendor refusal against the job as a moderation failure" do
         setup_signage_ai
         _, headers = Spec::Authentication.authentication