Skip to content

fix(loader): [PPT-2301] continuos loading failed repo - #91

Merged
stakach merged 2 commits into
masterfrom
PPT-2301
Nov 26, 2025
Merged

stakach merged 2 commits into
masterfrom
PPT-2301

Conversation

@naqvis

@naqvis naqvis commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@naqvis
naqvis requested review from chillfox and stakach November 25, 2025 06:03
@github-actions github-actions Bot added the type: bug something isn't working label Nov 25, 2025

@stakach stakach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually not sure we should stop retrying entirely.
Maybe we exponentially back-off as I want eventual consistency - i.e. transient failure or github is down we should recover without user intervention

Updating the error fields makes sense but I think possibly we have an in-memory retry counter and ramp up the back-off quickly like:

attempt = 1
fails
attempt +=1
sleep attempt ** 2
retry

etc

@github-actions github-actions Bot added type: bug something isn't working and removed type: bug something isn't working labels Nov 26, 2025
@naqvis
naqvis requested a review from stakach November 26, 2025 02:35

@stakach stakach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach
stakach merged commit 7009443 into master Nov 26, 2025
9 of 11 checks passed
@stakach
stakach deleted the PPT-2301 branch November 26, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants