Repository navigation
fix(app): stop a failed banner or upload list chunk from raising NG0750 - #330
Merged
Merged
Conversation
The global banner, upload list and update card load in @defer blocks with no @error block. When a chunk request fails (e.g. a flaky mobile network), Angular raises an uncaught NG0750 error. Empty @error blocks hide the optional UI instead. Fixes BACKOFFICE-4R Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Deployment failed for project backoffice with the following error: Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a flaky mobile network, the global banner and upload list chunks did not load. Angular then raised an uncaught NG0750 error, which Sentry reported as BACKOFFICE-4R. The chunks exist on the server, and the deploy was 16 hours old, so a stale deploy did not cause it.
The three
@deferblocks inAppComponenthad no@errorblock. Angular raises NG0750 only when no@errorblock exists. This PR adds empty@error {}blocks, so the optional UI stays hidden and no uncaught error occurs.Proof: I served a development build (like the nonprod deploy) and used Playwright to abort the two chunk requests. Before the fix, Chromium and WebKit each logged two NG0750 errors. After the fix, they logged none. Without blocked requests, both chunks still load and the components render. Lint, unit tests and the production build pass.
Fixes BACKOFFICE-4R
Reviewed with sol-loop: 1 round with gpt-6.1-sol on high. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code (T3 Code). Reviewed by GPT-6.1 Sol in Codex.
🤖 Generated with Claude Code