Repository navigation
Conversation
Wunka
self-requested a review
October 27, 2026 21:55
That loop is redundant and runs in rendering order, while the other loop runs in reverse rendering order, meaning that the two loops can render two different tooltips on top of each other.
Previously it would keep going until it managed to render a tooltip or ran out of windows to check. That means that if you hover over a button that has a tooltip, it would display the tooltip. Even if there was something else rendered on top of the button. Now it stops after it found the topmost window we are hovering over and asked it to render the tooltip.
It appears that I too can be wrong sometimes
Caused by 57e83bf
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2527 and #3318
Yoinked from #3242
Additionally adds tooltips for disabled buttons to explain why they can't be pressed right now.