Repository navigation
Added OnDiagonal Modifier [Modifier 2 of 4] - #2693
Crepestrom wants to merge 58 commits into
Conversation
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
|
please fix the formatting |
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
|
Requested Changes have been made |
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
|
rip formatting |
|
yipee it works |
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
…ubyz into Modifier-OnDiagonal
| } | ||
|
|
||
| pub fn printTooltip(self: *const OnDiagonal, outString: *main.ListManaged(u8)) void { | ||
| outString.print("if there is {} .{s} on diagonal lines", .{self.amount, self.tag.getName()}); |
There was a problem hiding this comment.
Please check this in-game and if the wording fits with other restrictions (e.g. and, not).
Also amount will usually be more than 1, so plural makes more sense is → are.
There was a problem hiding this comment.
the wording is changed
this is what it looks like now
There was a problem hiding this comment.
Ideally the output should be at least somewhat grammatically correct.
I think the wording for encased works well because encased is an adjective, not sure how to apply this here.
If you have trouble with wording, I think this is the one case where using an LLM would be acceptable.
There was a problem hiding this comment.
i have changed it to this
There was a problem hiding this comment.
Did you post the wrong screenshot? I see no difference to your previous comment.
There was a problem hiding this comment.
Either that or I went back to a old solution
There was a problem hiding this comment.
In my opinion this still feels more like what you see in a programming language and less like a human sentence.
There was a problem hiding this comment.
Hmm, yeah no, I don't really like this either, it still sounds weird on not.
For this I'd prefer the original if there is 1 .precios on diagonal lines, that at least forms proper sentences.
Sorry for holding this up for so long. I'll make an issue for improving not handling.
From #2650
-onDiagonal
Testing Addon
diagonal.zip