Repository navigation
fix(runtime): build main again: typeof's id-band test is is_handle_band after #12383 - #12385
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
pushed a commit
that referenced
this pull request
Oct 11, 2026
- instanceof, native method dispatch, stream consumers and StringDecoder no longer decode a plain number or subnormal double as a handle id; only POINTER-tagged values are handles. - js_readable_stream_from_blob/response (stdlib) and perry-ext-streams return tagged stream values. - field_set_by_name decodes the typed-receiver payload for stream expandos. - receiver_range LLVM literals are formatted at compile time from the shared constants; stale 0x100000 comments updated. - addr_class_inventory handle-floor rules cover every handle-band floor. - is_id_band -> is_handle_band repair in classify_value_typeof (same as #12385). - tests: test_gap_handleband2_decoder, test_gap_handleband2_live, unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main doesn't compile. #12383 renamed
addr_class::is_id_bandtois_handle_band; the handle band now ends at 0x200000 and includes the stream sub-band, so the two tests are identical. Meanwhile c387165 (objops) added a call to the old name inclassify_value_typeof. Each PR merged cleanly on its own, but together they break the build.This changes that one call. The identical change compiled on qb6 (
build-final-main.rc= 0 in the handleband2 lane's main arm). The call sits inside theis_pointer()branch, so it only sees tagged values, and its behaviour is unchanged.