Skip to content

Search for items by modifier in craft item menu. - #10318

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:feature/search-item-bases-by-effect
Open

Search for items by modifier in craft item menu.#10318
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:feature/search-item-bases-by-effect

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Fixes #10316

Description of the problem being solved:

When crafting an item through the crafting item menu, many item bases have implicits, enchants, or other modifiers that users would like to be able to search for. In this case, there are tons of Talismans and you might know you want one with "+1 Frenzy Charge" but you don't remember that it's a Cobra Talisman.

This PR is generalized to all item base items in the craft item menu. This can be useful when you're searching for a utility flask with res , so that the search is narrowed to Bismuth/Ruby/Topaz/Sapphire, etc.

The code here is modeled after the import character workflow which allows for searching by class or character name. We're adding support for implicits, enchants, base flasks, and base tinctures (even though they use implicits for the base item atm)

Steps taken to verify a working solution:

  • Run the tests included in the PR
  • Manually verify across different item categories and base types that partial string searches are returning only expected results
  • Run the full test suite
  • Used Codex to create a small benchmark that showed a <1 ms increase in time to create the index of all base entries, compared to just the base item name

Link to a build that showcases this PR:

Before screenshot:

image image image

After screenshot:

image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search talismans by effect

1 participant