Add individual skill weapon set handling - #2498
Open
LocalIdentity wants to merge 5 commits into
Open
Conversation
added 2 commits
September 2, 2026 01:11
Allow skill groups to use Both, Set 1, or Set 2. Calculate skills, effects, and stats using the assigned weapon set. Add logic to auto apply / disable weapon sets if a skill can't be used with it Make item and tree granted skills into supportable groups that lock the skill so it can't be removed. Hide item/tree only gems from the dropdown list due to them having proper groups now. Added a bunch of tests and tried to make sure there weren't any obvious performance issues
Skills granted via tree nodes have their level scaled based on your characters level so should level up or down Skills granted via items will set a maximum base level based on the item and will auto downscale based on if you meet the stat requirement and level requirement
added 3 commits
September 2, 2026 10:19
When levelling up your character, it was not updating the level of tree granted skills until you caused the socket group UI to refresh
When you set a minion to use weapon set 2 but had weapon set 1 active then it was hiding the skill set dropdowns in the sidebar and calcs tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Allow skill groups to use Both, Set 1, or Set 2.
Calculate skills, effects, and stats using the assigned weapon set.
Add logic to auto apply / disable weapon sets if a skill can't be used with it
Make item and tree granted skills into supportable groups that lock the skill so it can't be removed.
The skills correctly scale with level and stat requirements.
Hide item/tree only gems from the dropdown list due to them having proper groups now.
Added a bunch of tests and tried to make sure there weren't any obvious performance issues
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/spg8w10i
After screenshot: