Skip to content

deps: align moment and CSS selector parser with reviewed baseline #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chen21019 merged 2 commits into from
Oct 6, 2026
Merged

deps: align moment and CSS selector parser with reviewed baseline #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cf575c
deps: update moment and selector parser with reviewed lock baseline
chen21019 Oct 6, 2026
4617612
test: align exact Moment smoke version without weakening assertions
chen21019 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/baselines/npm-package-lock.sass-replacement.node24-ignore-scripts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"lodash.template": "file:vendor/lodash-template-compat/lodash.template-4.18.1-pasturestack.1.tgz",
"md5-jkmyers": "0.0.1",
"merge": "2.1.1",
"moment": "2.30.1",
"moment": "2.31.0",
"osenv": "file:vendor/osenv-compat/osenv-0.2.0-rc16.0.tgz",
"prismjs": "1.30.0",
"qrcode-generator": "2.0.4",
Expand Down Expand Up @@ -15359,9 +15359,9 @@
}
},
"node_modules/moment": {
"version": "2.30.1",
"resolved": "https://registry.npmjs.org/moment/-/moment-2.30.1.tgz",
"integrity": "sha512-uEmtNhbDOrWPFS+hdjFCBfy9f2YoyzRpwcl+DqpC6taX21FzsTLQVbMV/W7PzNSX6x/bhC1zA3c2UQ5NzH6how==",
"version": "2.31.0",
"resolved": "https://registry.npmjs.org/moment/-/moment-2.31.0.tgz",
"integrity": "sha512-0acOTfMiWOheYS4eoWb80yYMb/JLvVv9SHbs2PehaDzfUG0Bw855SKyk0IKTnPGa5+U2bmi3W68l1+sGLX/pvw==",
"dev": true,
"license": "MIT",
"engines": {
Expand Down Expand Up @@ -16326,9 +16326,9 @@
}
},
"node_modules/postcss-selector-parser": {
"version": "7.1.4",
"resolved": "https://registry.npmjs.org/postcss-selector-parser/-/postcss-selector-parser-7.1.4.tgz",
"integrity": "sha512-HeP7D2wyhkR+XaK6v4W8oRF62Dsz4flyuczALJp61GckGm42u1saSSJ/0auvcBqxs3jMRFEcPK34At/0JBKdOg==",
"version": "7.1.6",
"resolved": "https://registry.npmjs.org/postcss-selector-parser/-/postcss-selector-parser-7.1.6.tgz",
"integrity": "sha512-7qASPzhKF2l2KLboRZux8CCTRMdGiV08vWmyKzPz22qZ7ZjQBOeY7rNzNoCLSUiftJ7HUq0GERHmxw/t0dCdMw==",
"dev": true,
"license": "MIT",
"dependencies": {
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"lodash.template": "file:vendor/lodash-template-compat/lodash.template-4.18.1-pasturestack.1.tgz",
"md5-jkmyers": "0.0.1",
"merge": "2.1.1",
"moment": "2.30.1",
"moment": "2.31.0",
"osenv": "file:vendor/osenv-compat/osenv-0.2.0-rc16.0.tgz",
"prismjs": "1.30.0",
"qrcode-generator": "2.0.4",
Expand Down
12 changes: 6 additions & 6 deletions scripts/check-ui-moment-bower-migration
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ lock_path = Path("docs/baselines/npm-package-lock.sass-replacement.node24-ignore
lock = json.loads(lock_path.read_text(encoding="utf-8"))

dev_deps = package.get("devDependencies", {}) or {}
if dev_deps.get("moment") != "2.30.1":
fail("MOMENT_NPM_DEP_VERSION_UNEXPECTED", actual=dev_deps.get("moment"), expected="2.30.1")
if dev_deps.get("moment") != "2.31.0":
fail("MOMENT_NPM_DEP_VERSION_UNEXPECTED", actual=dev_deps.get("moment"), expected="2.31.0")
if "momentjs" in (bower.get("dependencies", {}) or {}):
fail("MOMENTJS_STILL_IN_BOWER_DEPENDENCIES")
if "node_modules/moment/moment.js" not in build:
Expand All @@ -38,11 +38,11 @@ if "bower_components/momentjs" in build:

packages = lock.get("packages", {}) or {}
root_dev = (packages.get("", {}) or {}).get("devDependencies", {}) or {}
if root_dev.get("moment") != "2.30.1":
fail("MOMENT_LOCK_ROOT_VERSION_UNEXPECTED", actual=root_dev.get("moment"), expected="2.30.1")
if root_dev.get("moment") != "2.31.0":
fail("MOMENT_LOCK_ROOT_VERSION_UNEXPECTED", actual=root_dev.get("moment"), expected="2.31.0")
moment_pkg = packages.get("node_modules/moment", {}) or {}
if moment_pkg.get("version") != "2.30.1":
fail("MOMENT_LOCK_PACKAGE_VERSION_UNEXPECTED", actual=moment_pkg.get("version"), expected="2.30.1")
if moment_pkg.get("version") != "2.31.0":
fail("MOMENT_LOCK_PACKAGE_VERSION_UNEXPECTED", actual=moment_pkg.get("version"), expected="2.31.0")

usage_count = 0
for root in [Path("app"), Path("addon"), Path("tests")]:
Expand Down
6 changes: 3 additions & 3 deletions scripts/node24-lock-smoke.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ function expectBrowserGlobalBundle(file, globalName, expectedVersion) {

function expectMomentRuntime() {
const moment = require("moment");
expectVersion("moment", "2.30.1");
expectVersion("moment", "2.31.0");
const start = moment.utc("2026-05-08T00:00:00Z");
const end = moment.utc("2026-05-08T00:01:30Z");
if (end.diff(start, "seconds") !== 90) {
Expand All @@ -873,13 +873,13 @@ function expectMomentRuntime() {
sandbox.self = sandbox;
vm.runInNewContext(code, sandbox, { filename: file });
const browserMoment = sandbox.moment || sandbox.window.moment;
if (!browserMoment || browserMoment.version !== "2.30.1") {
if (!browserMoment || browserMoment.version !== "2.31.0") {
fail("moment browser-global smoke failed");
}
if (browserMoment.utc("1982-02-24T18:42:00Z").format("MMMM") !== "February") {
fail("moment browser-global UTC format smoke failed");
}
console.log("moment-runtime-smoke-ok version=2.30.1");
console.log("moment-runtime-smoke-ok version=2.31.0");
}

function expectQrCodeGeneratorRuntime() {
Expand Down
Loading