Repository navigation
fix: reconcile owned CNI configurations across upgrades - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
IPsec Metadata renamed its CNI config, but the shared volume retained the previous active file. The CNI loader executed both and the historical wrapper still required Docker CLI.
Change
Validate and serialize desired files before writes; install each as an atomic mode-0600 regular file; stage managed.d before replacement; retire only an unrequested config matching the exact known platform filename/name/driver/IPAM contract. Preserve its bytes in a non-active recoverable backup. Reconcile the reverse rollback transition as well. Preserve foreign files and fail explicitly on ambiguous ownership, conflicting backups, symlinks or unsafe paths. Keep CNI data plane and firewall backend ownership unchanged.
Validation
Existing Windows Go 1.26.6 focused tests: 23 top-level tests; 29 leaf PASS, 7 symlink-privilege SKIP, 0 failure. Formatting and diff checks passed. Required Linux Go 1.27 race/build/security CI must pass before merge/release. Actual Catalog upgrade lifecycle verification follows formal publication; no runtime patch.