Repository navigation
HPO job count: bind name matches its parameter key - #843
Merged
Merged
Conversation
The maximum-HPO-jobs check in _check_task_with_unprocessed_inputs binds :taskid in its SQL and passes :taskID in its parameters. Oracle matches bind names without regard to case; the PostgreSQL cursor matches them exactly, so the query raises a missing-parameter KeyError there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the HPO job-count SQL bind-name correction.
No open issues 🎉
What changed in this PR
Fixes a PostgreSQL missing-parameter KeyError in the maximum-HPO-jobs check by aligning the parameter key with the SQL bind name.
Changes:
- Changes
:taskIDto:taskidin_check_task_with_unprocessed_inputs, preserving Oracle compatibility.
| File | Description |
|---|---|
pandaserver/taskbuffer/db_proxy_mods/task_complex_module.py |
Matches the HPO job-count parameter key to the SQL bind name. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum-HPO-jobs check in
_check_task_with_unprocessed_inputsbinds:taskidin its SQL and passes:taskIDin its parameters. Oracle matches bind names without regard to case; the PostgreSQL cursor matches them exactly, so on PostgreSQL the query raises a missing-parameterKeyErrorfor any HPO task with a maximum number of jobs. The parameter key now matches the bind.Found by a scan for bind names that differ from their keys only in case, after the same mismatch in
updateEventRangesfailed on every call on the ePIC server.🤖 Generated with Claude Code