Repository navigation
Resume updates the task's superStatus and DEFT status - #842
Merged
Merged
Conversation
A resume is carried out as the 'dummy' status (back to oldStatus), so the T_TASK and superStatus update, which tests the new status for running, ready or scouting after paused, never fired on a resume: the task ran with superStatus still 'paused' until its next status change. Judge the update on the status the task actually lands in. Every other command is unchanged (its new status is not dummy). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change aligning resumed tasks’ superStatus and DEFT status with their restored status.
No open issues 🎉
What changed in this PR
Fixes resume handling in getTasksToExecCommand_JEDI so a task’s superStatus and DEFT status reflect its restored status instead of remaining paused.
Changes:
- Computes
actualNewStatusbefore deciding whether to update the related statuses. - Uses the resolved status for update conditions and DEFT status mapping, preserving the existing scouting and staged mappings.
| File | Description |
|---|---|
pandaserver/taskbuffer/db_proxy_mods/task_complex_module.py |
Updates superStatus and DEFT status based on the task’s resolved destination status. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTasksToExecCommand_JEDIcarries out a resume as the statusdummy(back tooldStatus). Its T_TASK and superStatus update tests the new status for running, ready or scouting after paused, so on a resume it never fires: the resumed task keeps superStatus and DEFT statuspauseduntil its next status change, and anything reading superStatus sees a running task as paused.The update is now judged on the status the task lands in (
actualNewStatus, computed before the test), and writes the values the existing branch was written to write. Only resume behaves differently: avalanche and release also map todummy, but set their own status or none.Running on the ePIC PanDA server at BNL since 2026-10-30; a resume there now writes the DEFT status.
🤖 Generated with Claude Code