Skip to content

StopTB camp laptop data sync – = sync, inventory upload fixes and master download - #201

Merged
vanitha1822 merged 9 commits into
release-3.12.0from
vb/3.12.0-auto-sync
Oct 21, 2026
Merged

StopTB camp laptop data sync – = sync, inventory upload fixes and master download#201
vanitha1822 merged 9 commits into
release-3.12.0from
vb/3.12.0-auto-sync

fix(datasync): StopTB laptop upload uses the renamed reason_to_close …

184a7fd
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 21, 2026 in 1m 23s

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 111 in src/main/java/com/iemr/mmu/service/dataSyncActivity/DownloadDataFromServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik1j9ueU9fda0_rw&open=AaFcik1j9ueU9fda0_rw&pullRequest=201

Check failure on line 180 in src/main/java/com/iemr/mmu/service/dataSyncActivity/UploadDataToServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "totalRecords" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikzl9ueU9fda0_rl&open=AaFcikzl9ueU9fda0_rl&pullRequest=201

Check warning on line 172 in src/main/java/com/iemr/mmu/service/dataSyncActivity/UploadDataToServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikzl9ueU9fda0_rm&open=AaFcikzl9ueU9fda0_rm&pullRequest=201

Check failure on line 196 in src/main/java/com/iemr/mmu/service/dataSyncActivity/DownloadDataFromServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik1j9ueU9fda0_rx&open=AaFcik1j9ueU9fda0_rx&pullRequest=201

Check warning on line 110 in src/main/java/com/iemr/mmu/service/dataSyncActivity/DownloadDataFromServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik1j9ueU9fda0_rt&open=AaFcik1j9ueU9fda0_rt&pullRequest=201

Check warning on line 31 in src/test/java/com/iemr/mmu/service/dataSyncLayerCentral/GetDataFromVanAndSyncToDBVanKeysTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this variable to not match a restricted identifier. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik8B9ueU9fda0_r5&open=AaFcik8B9ueU9fda0_r5&pullRequest=201

Check warning on line 219 in src/main/java/com/iemr/mmu/controller/dataSyncActivity/StartSyncActivity.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik5h9ueU9fda0_r3&open=AaFcik5h9ueU9fda0_r3&pullRequest=201

Check warning on line 40 in src/test/java/com/iemr/mmu/service/dataSyncActivity/UploadSkipDuplicateGroupTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik8D9ueU9fda0_r_&open=AaFcik8D9ueU9fda0_r_&pullRequest=201

Check failure on line 148 in src/main/java/com/iemr/mmu/service/dataSyncLayerCentral/DataSyncRepositoryCentral.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "SELECT " 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikvp9ueU9fda0_rd&open=AaFcikvp9ueU9fda0_rd&pullRequest=201

Check warning on line 83 in src/main/java/com/iemr/mmu/service/dataSyncActivity/AutoSyncService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikzn9ueU9fda0_rs&open=AaFcikzn9ueU9fda0_rs&pullRequest=201

Check warning on line 22 in src/test/java/com/iemr/mmu/service/dataSyncActivity/UploadSkipDuplicateGroupTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik8D9ueU9fda0_r9&open=AaFcik8D9ueU9fda0_r9&pullRequest=201

Check warning on line 42 in src/test/java/com/iemr/mmu/service/dataSyncLayerCentral/GetDataFromVanAndSyncToDBVanKeysTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this variable to not match a restricted identifier. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik8B9ueU9fda0_r6&open=AaFcik8B9ueU9fda0_r6&pullRequest=201

Check warning on line 394 in src/main/java/com/iemr/mmu/service/dataSyncLayerCentral/GetDataFromVanAndSyncToDBImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the conditional expression inside this operation. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFciktw9ueU9fda0_ra&open=AaFciktw9ueU9fda0_ra&pullRequest=201

Check warning on line 370 in src/main/java/com/iemr/mmu/service/dataSyncLayerCentral/GetDataFromVanAndSyncToDBImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFciktw9ueU9fda0_rX&open=AaFciktw9ueU9fda0_rX&pullRequest=201

Check warning on line 68 in src/main/java/com/iemr/mmu/service/dataSyncActivity/AutoSyncService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikzn9ueU9fda0_rn&open=AaFcikzn9ueU9fda0_rn&pullRequest=201

Check failure on line 646 in src/main/java/com/iemr/mmu/service/dataSyncLayerCentral/GetDataFromVanAndSyncToDBImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "VanSerialNo" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFciktw9ueU9fda0_rY&open=AaFciktw9ueU9fda0_rY&pullRequest=201

Check failure on line 182 in src/main/java/com/iemr/mmu/service/dataSyncActivity/UploadDataToServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "failedRecords" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikzl9ueU9fda0_ri&open=AaFcikzl9ueU9fda0_ri&pullRequest=201

Check warning on line 160 in src/main/java/com/iemr/mmu/service/dataSyncActivity/DataSyncRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using a dynamically formatted SQL query is safe here. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik3f9ueU9fda0_r0&open=AaFcik3f9ueU9fda0_r0&pullRequest=201

Check warning on line 209 in src/main/java/com/iemr/mmu/service/dataSyncLayerCentral/DataSyncRepositoryCentralDownload.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikkK9ueU9fda0_rW&open=AaFcikkK9ueU9fda0_rW&pullRequest=201

Check failure on line 181 in src/main/java/com/iemr/mmu/service/dataSyncActivity/UploadDataToServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "successfulRecords" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikzl9ueU9fda0_rj&open=AaFcikzl9ueU9fda0_rj&pullRequest=201

Check warning on line 33 in src/test/java/com/iemr/mmu/service/dataSyncActivity/UploadSkipDuplicateGroupTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik8D9ueU9fda0_r-&open=AaFcik8D9ueU9fda0_r-&pullRequest=201

Check warning on line 209 in src/main/java/com/iemr/mmu/service/dataSyncLayerCentral/DataSyncRepositoryCentralDownload.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikkK9ueU9fda0_rV&open=AaFcikkK9ueU9fda0_rV&pullRequest=201

Check warning on line 80 in src/main/java/com/iemr/mmu/service/dataSyncActivity/AutoSyncService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcikzn9ueU9fda0_rr&open=AaFcikzn9ueU9fda0_rr&pullRequest=201

Check failure on line 110 in src/main/java/com/iemr/mmu/service/dataSyncActivity/DownloadDataFromServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik1j9ueU9fda0_rv&open=AaFcik1j9ueU9fda0_rv&pullRequest=201

Check warning on line 149 in src/main/java/com/iemr/mmu/service/dataSyncActivity/DataSyncRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaFcik3f9ueU9fda0_rz&open=AaFcik3f9ueU9fda0_rz&pullRequest=201
View more details on SonarQubeCloud