Skip to content

STOP-457: Automatic BenID download for StopTB laptops - #200

Merged
vishwab1 merged 3 commits into
release-3.12.0from
vb/3.12.0-stop457-benid
Oct 14, 2026
Merged

STOP-457: Automatic BenID download for StopTB laptops#200
vishwab1 merged 3 commits into
release-3.12.0from
vb/3.12.0-stop457-benid

chore: set MMU-API version to 3.12.0

b1887cb
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 14, 2026 in 53s

Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 250 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDN&open=AaE6FlcCghVCWurGbnDN&pullRequest=200

Check warning on line 386 in src/main/java/com/iemr/mmu/service/benid/CentralAuthService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcLghVCWurGbnDa&open=AaE6FlcLghVCWurGbnDa&pullRequest=200

Check warning on line 235 in src/main/java/com/iemr/mmu/service/benid/CentralAuthService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcLghVCWurGbnDZ&open=AaE6FlcLghVCWurGbnDZ&pullRequest=200

Check failure on line 206 in src/main/java/com/iemr/mmu/service/benid/CentralAuthService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "refreshToken" 5 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcLghVCWurGbnDb&open=AaE6FlcLghVCWurGbnDb&pullRequest=200

Check failure on line 236 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "errorMessage" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDP&open=AaE6FlcCghVCWurGbnDP&pullRequest=200

Check failure on line 400 in src/main/java/com/iemr/mmu/service/benid/CentralAuthService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Save and re-use this "Random". 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcLghVCWurGbnDd&open=AaE6FlcLghVCWurGbnDd&pullRequest=200

Check warning on line 46 in src/main/java/com/iemr/mmu/controller/benid/CentralAuthController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FldgghVCWurGbnDe&open=AaE6FldgghVCWurGbnDe&pullRequest=200

Check failure on line 198 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "datasync" 6 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDR&open=AaE6FlcCghVCWurGbnDR&pullRequest=200

Check warning on line 260 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use an "AtomicInteger" for this field; its operations are atomic. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDU&open=AaE6FlcCghVCWurGbnDU&pullRequest=200

Check warning on line 296 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof JSONObject jsonobject' 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDV&open=AaE6FlcCghVCWurGbnDV&pullRequest=200

Check failure on line 235 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "statusCode" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDO&open=AaE6FlcCghVCWurGbnDO&pullRequest=200

Check warning on line 333 in src/main/java/com/iemr/mmu/service/dataSyncActivity/DownloadDataFromServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlWUghVCWurGbnDJ&open=AaE6FlWUghVCWurGbnDJ&pullRequest=200

Check warning on line 211 in src/test/java/com/iemr/mmu/service/benid/CentralAuthServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotEquals instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlfnghVCWurGbnDi&open=AaE6FlfnghVCWurGbnDi&pullRequest=200

Check warning on line 222 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDM&open=AaE6FlcCghVCWurGbnDM&pullRequest=200

Check warning on line 327 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDL&open=AaE6FlcCghVCWurGbnDL&pullRequest=200

Check warning on line 280 in src/main/java/com/iemr/mmu/service/benid/CentralAuthService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof JSONObject jsonobject' 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcLghVCWurGbnDc&open=AaE6FlcLghVCWurGbnDc&pullRequest=200

Check failure on line 224 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "vanID" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDQ&open=AaE6FlcCghVCWurGbnDQ&pullRequest=200

Check warning on line 192 in src/test/java/com/iemr/mmu/service/benid/BenIdAutoTopUpServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotNull instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlfwghVCWurGbnDj&open=AaE6FlfwghVCWurGbnDj&pullRequest=200

Check warning on line 199 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDK&open=AaE6FlcCghVCWurGbnDK&pullRequest=200

Check warning on line 49 in src/main/java/com/iemr/mmu/controller/benid/CentralAuthController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FldgghVCWurGbnDf&open=AaE6FldgghVCWurGbnDf&pullRequest=200

Check warning on line 59 in src/main/java/com/iemr/mmu/controller/benid/CentralAuthController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FldgghVCWurGbnDg&open=AaE6FldgghVCWurGbnDg&pullRequest=200

Check warning on line 310 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use an "AtomicInteger" for this field; its operations are atomic. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDX&open=AaE6FlcCghVCWurGbnDX&pullRequest=200

Check warning on line 180 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDT&open=AaE6FlcCghVCWurGbnDT&pullRequest=200

Check warning on line 309 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "nextLong()" instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDW&open=AaE6FlcCghVCWurGbnDW&pullRequest=200

Check warning on line 72 in src/main/java/com/iemr/mmu/service/benid/BenIdAutoTopUpService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_MMU-API&issues=AaE6FlcCghVCWurGbnDS&open=AaE6FlcCghVCWurGbnDS&pullRequest=200
View more details on SonarQubeCloud