Skip to content

fix(stock-adjustment-draft): report save failures and show description #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snehar-nd merged 1 commit into from
Sep 23, 2026
Merged

fix(stock-adjustment-draft): report save failures and show description #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/app/app-modules/inventory/store-stock-adjustment/store-stock-adjustment.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,16 @@ export class StoreStockAdjustmentComponent
this.inventoryService
.saveStockAdjustmentDraft(temp)
.subscribe((response) => {
if (response?.statusCode !== 200) {
// don't report success on a failed save (that made a draft look
// saved while it never landed, so it was missing from the list)
this.confirmationService.alert(
response?.errorMessage ||
'Something went wrong. Please try again.',
'error',
);
return;
}
if (temp.stockAdjustmentDraftID) {
this.confirmationService.alert(
this.currentLanguageSet.inventory.updatedSuccessfully,
Expand Down
2 changes: 1 addition & 1 deletion ...stment/view-store-stock-adjustment-draft/view-store-stock-adjustment-draft.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<td z-table-cell>{{ i + 1 }}</td>
<td z-table-cell>{{ adjustment?.stockAdjustmentDraftID }}</td>
<td z-table-cell>{{ adjustment?.refNo }}</td>
<td z-table-cell>{{ adjustment?.draftDescription }}</td>
<td z-table-cell>{{ adjustment?.draftDesc }}</td>
<td z-table-cell>{{ adjustment?.createdBy }}</td>
<td z-table-cell>
{{ adjustment?.createdDate | istDate: "dd/MM/yyyy" }}
Expand Down
Loading