Skip to content

fix(dispense): stop repeating the invalid beneficiary-id alert #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snehar-nd merged 1 commit into from
Sep 23, 2026
Merged

fix(dispense): stop repeating the invalid beneficiary-id alert #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/app/app-modules/inventory/medicine-dispense/medicine-dispense.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ export class MedicineDispenseComponent implements OnInit, OnDestroy, DoCheck {
beneficiaryDetail: any;
beneficiaryVisitDetailList: any;
recentBeneficaryVisit: any;
lastCheckedBeneficiaryId: string | null = null;
checkBeneficiary() {
if (this.beneficiaryDetailForm.controls['beneficiaryID'].value === null) {
this.nullifyBeneficiaryDetails();
Expand All @@ -200,6 +201,14 @@ export class MedicineDispenseComponent implements OnInit, OnDestroy, DoCheck {
if (
this.beneficiaryDetailForm.controls['beneficiaryID'].value.length === 12
) {
const currentId =
this.beneficiaryDetailForm.controls['beneficiaryID'].value;
// (keyup) fires on every keypress even once maxlength holds the value at
// 12 chars, so skip re-querying (and re-alerting) an unchanged id.
if (currentId === this.lastCheckedBeneficiaryId) {
return;
}
this.lastCheckedBeneficiaryId = currentId;
this.inventoryService
.getBeneficaryVisitDetail({
providerServiceMapID:
Expand Down Expand Up @@ -273,6 +282,7 @@ export class MedicineDispenseComponent implements OnInit, OnDestroy, DoCheck {
}
}
nullifyBeneficiaryDetails() {
this.lastCheckedBeneficiaryId = null;
this.beneficiaryDetailForm.patchValue({
medicineDispenseType: null,
visitCode: null,
Expand Down
Loading